Skip to content

Add UIApplicationSupportsIndirectInputEvents migration #106889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Jul 14, 2022
Merged

Add UIApplicationSupportsIndirectInputEvents migration #106889

auto-submit merged 3 commits into from
Jul 14, 2022

Conversation

@moffatman
Copy link
Contributor

@moffatman moffatman commented Jun 30, 2022

Add a migration to add UIApplicationSupportsIndirectInputEvents: true in the iOS project Info.plist file. This flag was added to the template in #89944

Relevant to #23604

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Jun 30, 2022
@moffatman moffatman force-pushed the gestures_plist_migration branch from fb0d7ab to cbe7923 Compare June 30, 2022 18:16
jmagman
jmagman reviewed Jul 6, 2022
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about instead renaming MinimumFrameDurationMigration to HostAppInfoPlistMigration or similar, and adding/removing all relevant keys there, instead of creating a new, almost-identical migrator?

@jmagman
Copy link
Member

jmagman commented Jul 6, 2022

We should also consider adding these keys to https://docs.flutter.dev/development/add-to-app/ios/project-setup so add-to-app hosts can adopt as needed.

@moffatman
Copy link
Contributor Author

moffatman commented Jul 8, 2022

If we combine the migrations, each additional plist key would multiply the number of test scenarios in ios_project_migration_test.dart, since they would all run each time.

@jmagman
Copy link
Member

jmagman commented Jul 8, 2022

If we combine the migrations, each additional plist key would multiply the number of test scenarios in ios_project_migration_test.dart, since they would all run each time.

I think that's okay. You could get rid of your new add UIApplicationSupportsIndirectInputEvents key to info.plist migration group and the two "skip" tests, move your info.plist is migrated to use UIApplicationSupportsIndirectInputEvents test to the existing group, and there add a new one that both keys get migrated if needed. We're going to keep needing to edit the keys in this plist, and a new library each time with the _infoPlist boilerplate seems unnecessary.

jmagman
jmagman reviewed Jul 14, 2022
View reviewed changes
@moffatman moffatman force-pushed the gestures_plist_migration branch from 2bf82fb to e39fd18 Compare July 14, 2022 02:05
jmagman
jmagman approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, adding @christopherfujino for second review.

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 14, 2022
@jmagman
Copy link
Member

jmagman commented Jul 14, 2022

LGTM, adding @christopherfujino for second review.

Actually never mind forgot we don't need an extra reviewer here.

christopherfujino
christopherfujino approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@jmagman jmagman mentioned this pull request Jul 14, 2022
Open
@auto-submit auto-submit bot merged commit 902b012 into flutter:master Jul 14, 2022
This was referenced Jul 15, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 15, 2022
@engine-flutter-autoroll
902b012 Add UIApplicationSupportsIndirectInputEvents migration (flu…
69f50c1 
…tter/flutter#106889)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2022
@engine-flutter-autoroll
902b012 Add UIApplicationSupportsIndirectInputEvents migration (flu…
b09e16e 
…tter/flutter#106889)
@jmagman jmagman mentioned this pull request Jul 26, 2022
Merged
8 tasks
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@moffatman @camsim99
Add UIApplicationSupportsIndirectInputEvents migration (flutter#106889
bee5228 
)
erdemyerebasmaz added a commit to breez/c-breez that referenced this pull request Jan 25, 2023
@erdemyerebasmaz
Add UIApplicationSupportsIndirectInputEvents migration
c607857 
Add UIApplicationSupportsIndirectInputEvents migration by @moffatman in flutter/flutter#106889
erdemyerebasmaz added a commit to breez/c-breez that referenced this pull request Jan 25, 2023
@erdemyerebasmaz
Add UIApplicationSupportsIndirectInputEvents migration
2232683 
Add UIApplicationSupportsIndirectInputEvents migration by @moffatman in flutter/flutter#106889
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@moffatman @jmagman @christopherfujino