Skip to content

manual pub package roll; remove test_api pin, unblock bumping dwds #106887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Jul 6, 2022
Merged

manual pub package roll; remove test_api pin, unblock bumping dwds #106887

auto-submit merged 2 commits into from
Jul 6, 2022

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Jun 30, 2022

Fixes #106886

@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Jun 30, 2022
@christopherfujino
Copy link
Contributor Author

christopherfujino commented Jun 30, 2022

Ok, I need to fix compilation errors...

@christopherfujino
Copy link
Contributor Author

christopherfujino commented Jun 30, 2022

Ok, I need to fix compilation errors...

Turns out this was just a single nullable return type -> non-nullable extending a dwds interface.

christopherfujino
christopherfujino commented Jun 30, 2022
View reviewed changes
packages/flutter_tools/pubspec.yaml
dds: 2.2.1
dwds: 14.0.3
dds: 2.2.5
dwds: 15.0.0
Copy link
Contributor Author

@christopherfujino christopherfujino Jun 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @elliette

christopherfujino
christopherfujino commented Jun 30, 2022
View reviewed changes
packages/flutter_tools/pubspec.yaml
csslib: 0.17.2 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
dds_service_extensions: 1.3.0 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
devtools_shared: 2.14.0 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
dds_service_extensions: 1.3.1 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
Copy link
Contributor Author

@christopherfujino christopherfujino Jun 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @helin24

elliette
elliette approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@elliette elliette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! @helin24 is anything else needed for dart-lang/webdev#1632 ?

helin24
helin24 approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@helin24 helin24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for alerting me to this change! @elliette and @annagrin this covers the DWDS part of the change I needed to make.

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 30, 2022
@annagrin
Copy link
Contributor

annagrin commented Jul 1, 2022

LGTM!

@auto-submit auto-submit bot merged commit 19ac08d into flutter:master Jul 6, 2022
@christopherfujino christopherfujino deleted the manual-pub-roll branch July 6, 2022 17:30
@christopherfujino christopherfujino mentioned this pull request Jul 6, 2022
Closed
This was referenced Jul 7, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2022
@engine-flutter-autoroll
19ac08d manual pub package roll; remove test_api pin, unblock bumping…
aa7e7fa 
… dwds (flutter/flutter#106887)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 7, 2022
@engine-flutter-autoroll
19ac08d manual pub package roll; remove test_api pin, unblock bumping…
12ee7a7 
… dwds (flutter/flutter#106887)
@christopherfujino christopherfujino mentioned this pull request Jul 11, 2022
Closed
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@christopherfujino @camsim99
manual pub package roll; remove test_api pin, unblock bumping dwds (f…
740c29f 
…lutter#106887)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
19ac08d manual pub package roll; remove test_api pin, unblock bumping…
196c5ed 
… dwds (flutter/flutter#106887)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
19ac08d manual pub package roll; remove test_api pin, unblock bumping…
423dd63 
… dwds (flutter/flutter#106887)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@helin24 helin24 helin24 approved these changes

@elliette elliette elliette approved these changes

@Piinks Piinks Awaiting requested review from Piinks

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[flutter_tools] the tool manually pinning test_api is blocking rolling the latest dwds

4 participants

@christopherfujino @annagrin @helin24 @elliette