Skip to content

Fix dragging while the text selection toolbar is up doesn't hide toolbar #106878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
justinmc merged 1 commit into from
Jul 15, 2022
Merged

Fix dragging while the text selection toolbar is up doesn't hide toolbar #106878

justinmc merged 1 commit into from
Jul 15, 2022

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Jun 30, 2022

fixes #106820

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 30, 2022
@TahaTesser TahaTesser requested a review from justinmc June 30, 2022 14:29
justinmc
justinmc approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

packages/flutter/lib/src/cupertino/text_field.dart
if (cause == SelectionChangedCause.drag) {
_editableText.hideToolbar();
}
break;
Copy link
Contributor

@justinmc justinmc Jul 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first I thought it was strange to have two switches on the platform back to back, but I think it makes sense. Otherwise you'd have to duplicate a bunch of code in a single switch.

@justinmc justinmc merged commit 1bc787e into flutter:master Jul 15, 2022
@TahaTesser TahaTesser deleted the fix_drag_selection_hide_toolbar branch July 15, 2022 18:19
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
327a6a3 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
30a7e0e 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
8b1088a 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
b8763a9 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
0453994 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
c410203 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
4eb6ce9 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
8ede64e 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
7fd3c74 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
7dd8d09 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
2bbe7ae 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
db08607 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
50051e7 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
7ca4f01 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
3a273d9 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
0775b26 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
16f9ea9 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
6748d24 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
b87e4ea 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
414207d 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
813fad3 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
6f9533d 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
1aac46c 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
7b6e610 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
6e90191 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
a449cb9 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
8b6b580 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
11d99a8 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
dba3e19 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
c9649b9 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
9de4f9a 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
ef44645 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
27787bb 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
dafe3e6 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
54eff31 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
d7d55c5 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
bbdff72 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
c5297cb 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
70db4f9 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
097c848 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
3859f6b 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
ceac117 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
2dddd3a 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
06ed324 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
475ccbc 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
1ca9079 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
a581d06 
…ide toolbar (flutter/flutter#106878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
1bc787e Fix dragging while the text selection toolbar is up doesn't h…
0fc6e45 
…ide toolbar (flutter/flutter#106878)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@TahaTesser @camsim99
Fix dragging while the text selection toolbar is up doesn't hide tool…
9887a67 
…bar (flutter#106878)

Fixes a fidelity bug on desktop involving the selection toolbar not hiding when it should have.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dragging while the text selection toolbar is up should close it

2 participants

@TahaTesser @justinmc