Skip to content

[Windows] Remove the usage of SETLOCAL ENABLEDELAYEDEXPANSION from bat scripts. #106861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Jul 14, 2022
Merged

[Windows] Remove the usage of SETLOCAL ENABLEDELAYEDEXPANSION from bat scripts. #106861

auto-submit merged 2 commits into from
Jul 14, 2022

Conversation

@moko256
Copy link
Contributor

@moko256 moko256 commented Jun 30, 2022

On Windows, calling another script without CALL from bat script won't back to caller when callee exited. The callee can use last exit code. When the callee exits with exit code, the caller's caller can receive the code.

This PR replaces the usage of SETLOCAL ENABLEDELAYEDEXPANSION with this behavior.
This PR also replaces the usage of it which can be replaced by normal %~%.

Fixes #26571.

No changes in the flutter/tests repo.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Jun 30, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@moko256
Copy link
Contributor Author

moko256 commented Jun 30, 2022

I added a test.

@goderbauer goderbauer added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 1, 2022
@christopherfujino
Copy link
Contributor

christopherfujino commented Jul 14, 2022

@loic-sharma would you by any chance know how batch files work, and be able to review this change?

loic-sharma
loic-sharma approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

christopherfujino
christopherfujino approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM, thanks for this change!

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 14, 2022
@auto-submit auto-submit bot merged commit 45e212e into master Jul 14, 2022
@auto-submit auto-submit bot deleted the moko256_win_avoid_enabledelayedexpansion branch July 14, 2022 21:56
This was referenced Jul 15, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 15, 2022
@engine-flutter-autoroll
45e212e [Windows] Remove the usage of `SETLOCAL ENABLEDELAYEDEXPANSIO…
8e7ef84 
…N` from bat scripts. (flutter/flutter#106861)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2022
@engine-flutter-autoroll
45e212e [Windows] Remove the usage of `SETLOCAL ENABLEDELAYEDEXPANSIO…
c50d958 
…N` from bat scripts. (flutter/flutter#106861)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@moko256 @camsim99
[Windows] Remove the usage of SETLOCAL ENABLEDELAYEDEXPANSION from …
010571c 
…bat scripts. (flutter#106861)
@moko256 moko256 mentioned this pull request Sep 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loic-sharma loic-sharma loic-sharma approved these changes

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Windows failure if install directory has a "!" in it

4 participants

@moko256 @christopherfujino @loic-sharma @goderbauer