Skip to content

Conversation

@fluttergithubbot
Copy link
Contributor

This PR was generated by flutter update-packages --force-upgrade.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 29, 2022
@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. team: flakes c: tech-debt Technical debt, code quality, testing, etc. labels Jun 29, 2022
@christopherfujino
Copy link
Contributor

@elliette to diagnose why dwds is did not get bumped, I temporarily added 'dwds': '15.0.0', to the manual pin map: https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/commands/update_packages.dart#L29, and ran flutter update-packages --force-upgrade and got this error from pub:

Because test_core >=0.4.14 <0.4.15 depends on test_api 0.4.10 and test_core >=0.4.11 <0.4.14 depends on vm_service >=6.0.0 <9.0.0, test_core >=0.4.11 <0.4.15 requires test_api 0.4.10 or vm_service >=6.0.0 <9.0.0.
And because dwds >=15.0.0 depends on vm_service ^9.0.0, if dwds >=15.0.0 and test_core >=0.4.11 <0.4.15 then test_api 0.4.10.
And because test_core >=0.4.15 depends on test_api 0.4.11 and flutter_update_packages depends on test_api 0.4.9, dwds >=15.0.0 is incompatible with test_core >=0.4.11.
So, because flutter_update_packages depends on both dwds 15.0.0 and test_core >=0.4.13, version solving failed.

Because we're also manually pinning test_api. Let me file a bug for this....

@christopherfujino
Copy link
Contributor

Done: #106886.

Gonna approve this PR and work to roll test_api separately.

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 30, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 30, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 30, 2022

Validations Fail.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 30, 2022
@christopherfujino
Copy link
Contributor

Actually, I think I can manually remove one of the pins so we can bump dwds.

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been superceded by my manual roll: #106887. Please do not close this until that PR merges, or else the autoroller will try to roll it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants