Ignore invalid description in vswhere.exe JSON output #106836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
loic-sharma
commented
Jun 30, 2022
packages/flutter_tools/test/general.shard/windows/visual_studio_test.dart
Show resolved
Hide resolved
loic-sharma
requested review from
christopherfujino,
gspencergoog,
jonahwilliams and
stuartmorgan-g
stuartmorgan-g
approved these changes
Jun 30, 2022
packages/flutter_tools/test/general.shard/windows/visual_studio_test.dart
Outdated
Show resolved
Hide resolved
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 1, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 1, 2022
8 tasks
loic-sharma
added a commit
to loic-sharma/flutter
that referenced
this pull request
Jul 11, 2022
…er#106836) The `flutter doctor` command uses `vswhere.exe` to verify the Visual Studio installation. This `vswhere.exe` is known to encode its output incorrectly. This is problematic as the `description` property is localized, and in certain languages this results in invalid JSON due to the incorrect encoding. This change introduces a fallback to our `vswhere.exe` output parsing logic: if parsing JSON fails, remove the `description` property and retry parsing the JSON. This fix was also tested on the outputs provided here: flutter#106601 (comment) Addresses flutter#106601
itsjustkevin
pushed a commit
that referenced
this pull request
Jul 12, 2022
…) (#107328) The `flutter doctor` command uses `vswhere.exe` to verify the Visual Studio installation. This `vswhere.exe` is known to encode its output incorrectly. This is problematic as the `description` property is localized, and in certain languages this results in invalid JSON due to the incorrect encoding. This change introduces a fallback to our `vswhere.exe` output parsing logic: if parsing JSON fails, remove the `description` property and retry parsing the JSON. This fix was also tested on the outputs provided here: #106601 (comment) Addresses #106601
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
…er#106836) The `flutter doctor` command uses `vswhere.exe` to verify the Visual Studio installation. This `vswhere.exe` is known to encode its output incorrectly. This is problematic as the `description` property is localized, and in certain languages this results in invalid JSON due to the incorrect encoding. This change introduces a fallback to our `vswhere.exe` output parsing logic: if parsing JSON fails, remove the `description` property and retry parsing the JSON. This fix was also tested on the outputs provided here: flutter#106601 (comment) Addresses flutter#106601
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
flutter doctorcommand usesvswhere.exeto verify the Visual Studio installation. Thisvswhere.exeis known to encode its output incorrectly. This is problematic as thedescriptionproperty is localized, and in certain languages this results in invalid JSON due to the incorrect encoding.This change introduces a fallback to our
vswhere.exeoutput parsing logic: if parsing JSON fails, remove thedescriptionproperty and retry parsing the JSON.This fix was also tested on the outputs provided here: #106601 (comment)
Addresses #106601.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.