Skip to content

plugin_ffi warn about lack of platform support #106813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Jun 29, 2022
Merged

plugin_ffi warn about lack of platform support #106813

fluttergithubbot merged 1 commit into from
Jun 29, 2022

Conversation

@dcharkes
Copy link
Contributor

@dcharkes dcharkes commented Jun 29, 2022 •
edited
Loading

flutter create --template=plugin_ffi doesn't warn about lack of platform support, causing confusion for users.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@dcharkes dcharkes requested a review from stuartmorgan-g June 29, 2022 16:29
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 29, 2022
stuartmorgan-g
stuartmorgan-g approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Sorry I missed this in the initial review.

@dcharkes
Copy link
Contributor Author

dcharkes commented Jun 29, 2022

Thanks for the quick review and the pointers!

@fluttergithubbot fluttergithubbot merged commit e4bde83 into master Jun 29, 2022
@fluttergithubbot fluttergithubbot deleted the plugin-ffi-warn-no-platforms branch June 29, 2022 17:29
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2022
@engine-flutter-autoroll
e4bde83 plugin_ffi warn about lack of platform support (flutter/flutt…
c29aa21 
…er#106813)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2022
@engine-flutter-autoroll
e4bde83 plugin_ffi warn about lack of platform support (flutter/flutt…
e4ac0ed 
…er#106813)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2022
@engine-flutter-autoroll
e4bde83 plugin_ffi warn about lack of platform support (flutter/flutt…
881f9dc 
…er#106813)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2022
@engine-flutter-autoroll
e4bde83 plugin_ffi warn about lack of platform support (flutter/flutt…
3221376 
…er#106813)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 30, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 30, 2022
@engine-flutter-autoroll
e4bde83 plugin_ffi warn about lack of platform support (flutter/flutt…
633a69d 
…er#106813)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@dcharkes @camsim99
plugin_ffi warn about lack of platform support (flutter#106813)
6dd4d4d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
e4bde83 plugin_ffi warn about lack of platform support (flutter/flutt…
569972f 
…er#106813)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
e4bde83 plugin_ffi warn about lack of platform support (flutter/flutt…
00581e4 
…er#106813)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dcharkes @stuartmorgan-g @fluttergithubbot