Reland "fix a Scaffold.bottomSheet update bug" #106775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
Member
Author
|
I know why the original patch breaks tests now, change the key will cause the subtree unmount from the tree and disposal. |
Contributor
Nice catch! I will run this against internal tests and see if it still causes any breaks. |
Piinks
approved these changes
Jun 29, 2022
Contributor
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
LGTM - but do not merge. Approval is necessary to run the test suite.
Piinks
changed the title
Contributor
|
Marked as WIP so the bot will not accidentally merge. :) |
Piinks
changed the title
Contributor
|
Confirmed this no longer breaks internal tests. 🎉 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 1, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 1, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reland #83689
Reverted by #83904
Fixes #83668
I change a solution to fix the issue and I am not sure whether this still breaks the G-test.