Skip to content

Revert "Disable cursor opacity animation on macOS, make iOS cursor animation discrete (#104335)" #106762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Jun 28, 2022
Merged

Revert "Disable cursor opacity animation on macOS, make iOS cursor animation discrete (#104335)" #106762

auto-submit merged 1 commit into from
Jun 28, 2022

Conversation

@LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Jun 28, 2022

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 28, 2022
@LongCatIsLooong LongCatIsLooong marked this pull request as ready for review June 28, 2022 21:47
@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 28, 2022
@auto-submit auto-submit bot merged commit 8124191 into flutter:master Jun 28, 2022
@LongCatIsLooong LongCatIsLooong deleted the revert-104335 branch June 28, 2022 22:19
XilaiZhang pushed a commit to XilaiZhang/flutter that referenced this pull request Jun 28, 2022
@LongCatIsLooong @XilaiZhang
Revert "Disable cursor opacity animation on macOS, make iOS cursor an…
9c9ce69 
…imation discrete (flutter#104335)" (flutter#106762)
@XilaiZhang XilaiZhang mentioned this pull request Jun 28, 2022
Merged
XilaiZhang added a commit that referenced this pull request Jun 28, 2022
@XilaiZhang @LongCatIsLooong
Revert "Disable cursor opacity animation on macOS, make iOS cursor an…
a8580fb 
…imation discrete (#104335)" (#106762) (#106766)

Co-authored-by: LongCatIsLooong <[email protected]>
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 29, 2022
@engine-flutter-autoroll
8124191 Revert "Disable cursor opacity animation on macOS, make iOS c…
4b231e9 
…ursor animation discrete (#104335)" (flutter/flutter#106762)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2022
@engine-flutter-autoroll
8124191 Revert "Disable cursor opacity animation on macOS, make iOS c…
4957f52 
…ursor animation discrete (#104335)" (flutter/flutter#106762)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2022
@engine-flutter-autoroll
8124191 Revert "Disable cursor opacity animation on macOS, make iOS c…
2261585 
…ursor animation discrete (#104335)" (flutter/flutter#106762)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2022
@engine-flutter-autoroll
8124191 Revert "Disable cursor opacity animation on macOS, make iOS c…
06d67b1 
…ursor animation discrete (#104335)" (flutter/flutter#106762)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2022
@engine-flutter-autoroll
8124191 Revert "Disable cursor opacity animation on macOS, make iOS c…
ac4b9d8 
…ursor animation discrete (#104335)" (flutter/flutter#106762)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2022
@engine-flutter-autoroll
8124191 Revert "Disable cursor opacity animation on macOS, make iOS c…
c02cf3b 
…ursor animation discrete (#104335)" (flutter/flutter#106762)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2022
@engine-flutter-autoroll
8124191 Revert "Disable cursor opacity animation on macOS, make iOS c…
1d93196 
…ursor animation discrete (#104335)" (flutter/flutter#106762)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2022
@engine-flutter-autoroll
8124191 Revert "Disable cursor opacity animation on macOS, make iOS c…
0f23df9 
…ursor animation discrete (#104335)" (flutter/flutter#106762)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2022
@engine-flutter-autoroll
8124191 Revert "Disable cursor opacity animation on macOS, make iOS c…
191bf02 
…ursor animation discrete (#104335)" (flutter/flutter#106762)
LongCatIsLooong added a commit to LongCatIsLooong/flutter that referenced this pull request Jun 30, 2022
@LongCatIsLooong
Reland "Disable cursor opacity animation on macOS, make iOS cursor
ef81ff6 
animation discrete (flutter#104335)" (reverted in flutter#106762)

This reverts commit 8124191.
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@LongCatIsLooong @camsim99
Revert "Disable cursor opacity animation on macOS, make iOS cursor an…
7d92cf2 
…imation discrete (flutter#104335)" (flutter#106762)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
8124191 Revert "Disable cursor opacity animation on macOS, make iOS c…
bf90697 
…ursor animation discrete (#104335)" (flutter/flutter#106762)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
8124191 Revert "Disable cursor opacity animation on macOS, make iOS c…
ff23328 
…ursor animation discrete (#104335)" (flutter/flutter#106762)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@XilaiZhang XilaiZhang XilaiZhang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LongCatIsLooong @XilaiZhang