Refactor sample catalog screenshot production #10676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
yjbanov
approved these changes
Jun 14, 2017
| await flutter('packages', options: <String>['get']); | ||
|
|
||
| if (deviceOperatingSystem == DeviceOperatingSystem.ios) | ||
| final bool isIOSDevice = deviceOperatingSystem == DeviceOperatingSystem.ios; |
Contributor
There was a problem hiding this comment.
nit: for consistency with other code, let's treat "ios" as a plain word and camel-case it like this: isIosDevice.
dev/devicelab/pubspec.yaml
Outdated
|
|
||
| dependencies: | ||
| args: ^0.13.4 | ||
| image: |
Contributor
There was a problem hiding this comment.
In most other places we're more specific about the version. How about ^1.1.27?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The (Java) code used to save screenshots has been flaky on Linux. Refactored the code so that screenshot production can run on (just) MacOS.
Also: