Add Windows to the platform_channels example #106754

stuartmorgan-g · 2022-06-28T20:36:38Z

Adds Windows support to the platform_channels example, implementing battery querying and charge state listening/reporting.

This is mostly flutter create boilerplate; see individual commits for actual changes.

Also fixes the license check script to check .cpp files, and fixes the new violations that found.

Part of #79204

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

flutter-dashboard · 2022-06-28T20:36:42Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

stuartmorgan-g · 2022-06-28T20:46:03Z

@cbracken @gspencergoog Do we not have any devicelab Windows tests? I noticed that hello_world still doesn't have a windows directory. I thought we had enabled one app at some point, but maybe I'm misremembering?

Ideally we'd be running the driver tests for all the examples on Windows, but I didn't see any place we already have that set up.

examples/platform_channel/windows/runner/CMakeLists.txt

examples/platform_channel/windows/runner/Runner.rc

loic-sharma · 2022-06-28T22:00:04Z

Consider adding a note to the example's README about Windows support: https://github.com/flutter/flutter/tree/master/examples/platform_channel#example-of-calling-platform-services-from-flutter

stuartmorgan-g · 2022-06-29T18:26:07Z

.ci.yaml

      - bin/**
      - .ci.yaml

+  - name: Windows platform_channel_sample_test_windows


@keyonghan Does this look right? As usual with .ci.yaml changes I don't do it often enough to remember how to manually test this in advance, and since it's bringup it won't be tested here.

The ci config looks good to me.
You may want to add the test ownership entry in https://github.com/flutter/flutter/blob/master/TESTOWNERS#L218 by following:

# Windows platform_channel_sample_test_windows <path-to-test> @<owner> @<team>

Done. I gave it to @cbracken since desktop seemed like the best fit for it, but we could adjust it to me+plugins later if it turns out to be problematic.

stuartmorgan-g · 2022-06-29T18:26:35Z

dev/devicelab/lib/tasks/integration_tests.dart

 }

-TaskFunction createPlatformChannelSampleTest() {
+TaskFunction createPlatformChannelSampleTest({String? deviceIdOverride}) {


This and the change below follow the pattern from #45264

stuartmorgan-g · 2022-06-29T18:27:22Z

@cbracken @gspencergoog Do we not have any devicelab Windows tests? I noticed that hello_world still doesn't have a windows directory. I thought we had enabled one app at some point, but maybe I'm misremembering?

Ideally we'd be running the driver tests for all the examples on Windows, but I didn't see any place we already have that set up.

I think I figured out setting this up 🤞🏻. Added to the PR.

stuartmorgan-g · 2022-06-29T18:28:07Z

Consider adding a note to the example's README about Windows support: https://github.com/flutter/flutter/tree/master/examples/platform_channel#example-of-calling-platform-services-from-flutter

Done.

keyonghan

Configs LGTM.

cbracken

lgtm

stuartmorgan-g · 2022-06-30T14:07:20Z

While fixing the missing licenses, I noticed that it was only flagging the .h files, not the .cpp files, so I fixed the script that checks this to check cpp files (we were only getting .h because it was configured for Obj-C already). And then fixed the missing licenses in other Windows examples.

This adds a Windows section to the existing iOS and Android section, following the same structure as those examples, and using the code from flutter/flutter#106754 Part of flutter/flutter#79204

…#106754)

This adds a Windows section to the existing iOS and Android section, following the same structure as those examples, and using the code from flutter/flutter#106754 Part of flutter/flutter#79204

…#106754)

stuartmorgan-g added 3 commits June 28, 2022 11:57

Boilerplate

1d72c77

First half: battery level

7c8911b

Implement charge listener

cc17557

stuartmorgan-g requested review from cbracken and loic-sharma June 28, 2022 20:36

flutter-dashboard bot added d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jun 28, 2022

loic-sharma reviewed Jun 28, 2022

View reviewed changes

examples/platform_channel/windows/runner/CMakeLists.txt Show resolved Hide resolved

loic-sharma reviewed Jun 28, 2022

View reviewed changes

examples/platform_channel/windows/runner/Runner.rc Show resolved Hide resolved

loic-sharma approved these changes Jun 28, 2022

View reviewed changes

stuartmorgan-g added 5 commits June 29, 2022 12:14

Remove ICO

31fce13

Merge branch 'main' into platform-channel-example-windows

4532383

Regenerate app from template

0b9ac64

Update README

0d8f9e1

Add devicelab test in bringup mode

0cf7efd

stuartmorgan-g requested a review from keyonghan as a code owner June 29, 2022 18:18

Bringup

1ae7310

stuartmorgan-g commented Jun 29, 2022

View reviewed changes

Added codeowner

b230586

keyonghan approved these changes Jun 29, 2022

View reviewed changes

cbracken approved these changes Jun 30, 2022

View reviewed changes

License and license check fixes

ac0d133

flutter-dashboard bot added the d: api docs Issues with https://api.flutter.dev/ label Jun 30, 2022

flutter-dashboard bot added the documentation label Jun 30, 2022

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 30, 2022

stuartmorgan-g mentioned this pull request Jun 30, 2022

Add Windows to platform channel example flutter/website#7328

Merged

3 tasks

auto-submit bot merged commit 6c6ae06 into flutter:master Jun 30, 2022

engine-flutter-autoroll mentioned this pull request Jun 30, 2022

Roll Flutter from 3b11ad8cfe78 to 6c6ae063814c (28 revisions) flutter/plugins#6060

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 30, 2022

6c6ae06 Add Windows to the platform_channels example (flutter/flutter…

cceb603

…#106754)

engine-flutter-autoroll mentioned this pull request Jun 30, 2022

Roll Flutter from 2c13db3b22dd to 6c6ae063814c (16 revisions) flutter/packages#2296

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 30, 2022

6c6ae06 Add Windows to the platform_channels example (flutter/flutter…

9d804f1

…#106754)

engine-flutter-autoroll mentioned this pull request Jun 30, 2022

Roll Flutter from 2c13db3b22dd to cf6b91d0ec2a (17 revisions) flutter/packages#2297

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 30, 2022

6c6ae06 Add Windows to the platform_channels example (flutter/flutter…

b684053

…#106754)

stuartmorgan-g deleted the platform-channel-example-windows branch June 30, 2022 16:21

camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022

Add Windows to the platform_channels example (flutter#106754)

91210b7

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022

6c6ae06 Add Windows to the platform_channels example (flutter/flutter…

69cc508

…#106754)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022

6c6ae06 Add Windows to the platform_channels example (flutter/flutter…

bd7f4ee

…#106754)

Add Windows to the platform_channels example #106754

Add Windows to the platform_channels example #106754

Uh oh!

Conversation

stuartmorgan-g commented Jun 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Jun 28, 2022

Uh oh!

stuartmorgan-g commented Jun 28, 2022

Uh oh!

Uh oh!

Uh oh!

loic-sharma commented Jun 28, 2022

Uh oh!

stuartmorgan-g Jun 29, 2022

Choose a reason for hiding this comment

Uh oh!

keyonghan Jun 29, 2022

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Jun 29, 2022

Choose a reason for hiding this comment

Uh oh!

cbracken Jun 30, 2022

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Jun 29, 2022

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Jun 29, 2022

Uh oh!

stuartmorgan-g commented Jun 29, 2022

Uh oh!

keyonghan left a comment

Choose a reason for hiding this comment

Uh oh!

cbracken left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Jun 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

stuartmorgan-g commented Jun 28, 2022 •

edited

Loading