Skip to content

DropdownButton: Fix hint alignment when selectedItemBuilder is non-null. #106731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Jul 15, 2022
Merged

DropdownButton: Fix hint alignment when selectedItemBuilder is non-null. #106731

auto-submit merged 1 commit into from
Jul 15, 2022

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Jun 28, 2022

fixes #106717

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 28, 2022
@TahaTesser TahaTesser requested a review from QuncCccccc June 28, 2022 10:47
QuncCccccc
QuncCccccc approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@TahaTesser TahaTesser force-pushed the fix_selectedItemBuilder_hint_alignment branch from 4c8bf4a to 831dece Compare July 15, 2022 07:43
@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 15, 2022
@auto-submit auto-submit bot merged commit bbec650 into flutter:master Jul 15, 2022
@TahaTesser TahaTesser deleted the fix_selectedItemBuilder_hint_alignment branch July 15, 2022 09:56
@TahaTesser TahaTesser mentioned this pull request Jul 15, 2022
Closed
This was referenced Jul 15, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 15, 2022
@engine-flutter-autoroll
bbec650 DropdownButton: Fix hint alignment when `selectedItemBuilde…
c719630 
…r` is non-null. (flutter/flutter#106731)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2022
@engine-flutter-autoroll
bbec650 DropdownButton: Fix hint alignment when `selectedItemBuilde…
2e9bf5b 
…r` is non-null. (flutter/flutter#106731)
@TahaTesser TahaTesser mentioned this pull request Jul 21, 2022
Closed
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@TahaTesser @camsim99
DropdownButton: Fix hint alignment when selectedItemBuilder is no…
8e81a74 
…n-null. (flutter#106731)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuncCccccc QuncCccccc QuncCccccc approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DropdownButton's hint alignment is affected by selectedItemBuilder

2 participants

@TahaTesser @QuncCccccc