Oops, fix code coverage #10672
Merged
Oops, fix code coverage #10672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And add comments explaining why.
Contributor
|
Can we test this? |
Contributor
Author
|
It's currently failing on Travis, so in some sense we already are. (I don't understand why it wasn't caught by the presubmit, though.) |
Contributor
Because we don't run overage on PRs - it takes too long. |
tvolkert
approved these changes
Jun 13, 2017
Contributor
|
This reduced our coverage to zero. I'm going to say that didn't fix the problem. :-) |
Contributor
Author
|
Well, I didn't really look at it, just made tests pass again :-) I guess we need a test that coverage is not zero. |
Contributor
|
This wiki page talks about how coverage for Flutter: https://github.com/flutter/flutter/wiki/Test-coverage-for-package%3Aflutter |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add comments explaining why.