Skip to content

Consistently capitalize Endpoint (not EndPoint) #106706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
christopherfujino merged 1 commit into from
Jun 28, 2022
Merged

Consistently capitalize Endpoint (not EndPoint) #106706

christopherfujino merged 1 commit into from
Jun 28, 2022

Conversation

@justinmc
Copy link
Contributor

@justinmc justinmc commented Jun 27, 2022 •
edited
Loading

Some places in the code base were using selectionEndpoints and elsewhere it was selectionEndPoints:

flutter/packages/flutter/lib/src/widgets/text_selection.dart

Line 1015 in b731aee

selectionEndpoints: selectionEndPoints,

This PR standardizes the capitalization to selectionEndpoints.

@justinmc justinmc self-assigned this Jun 27, 2022
@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Jun 27, 2022
Renzo-Olivares
Renzo-Olivares approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino christopherfujino mentioned this pull request Jun 28, 2022
Closed
@christopherfujino
Copy link
Contributor

christopherfujino commented Jun 28, 2022

Merging this on a red luci-flutter check to fix the tree after #106755

@christopherfujino christopherfujino merged commit baf8686 into flutter:master Jun 28, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 28, 2022
@engine-flutter-autoroll
baf8686 Consistently capitalize Endpoint (not EndPoint) (flutter/flut…
d50e30e 
…ter#106706)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2022
@engine-flutter-autoroll
baf8686 Consistently capitalize Endpoint (not EndPoint) (flutter/flut…
c929aa9 
…ter#106706)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2022
@engine-flutter-autoroll
baf8686 Consistently capitalize Endpoint (not EndPoint) (flutter/flut…
1061a75 
…ter#106706)
@justinmc justinmc deleted the end-points branch June 29, 2022 16:29
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2022
@engine-flutter-autoroll
baf8686 Consistently capitalize Endpoint (not EndPoint) (flutter/flut…
06df7ea 
…ter#106706)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2022
@engine-flutter-autoroll
baf8686 Consistently capitalize Endpoint (not EndPoint) (flutter/flut…
15f43d4 
…ter#106706)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2022
@engine-flutter-autoroll
baf8686 Consistently capitalize Endpoint (not EndPoint) (flutter/flut…
2d69359 
…ter#106706)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2022
@engine-flutter-autoroll
baf8686 Consistently capitalize Endpoint (not EndPoint) (flutter/flut…
b14fca0 
…ter#106706)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2022
@engine-flutter-autoroll
baf8686 Consistently capitalize Endpoint (not EndPoint) (flutter/flut…
fdef816 
…ter#106706)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2022
@engine-flutter-autoroll
baf8686 Consistently capitalize Endpoint (not EndPoint) (flutter/flut…
5418168 
…ter#106706)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@justinmc @camsim99
Consistently capitalize Endpoint (not EndPoint) (flutter#106706)
da01ad1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
baf8686 Consistently capitalize Endpoint (not EndPoint) (flutter/flut…
a4e7279 
…ter#106706)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
baf8686 Consistently capitalize Endpoint (not EndPoint) (flutter/flut…
0840460 
…ter#106706)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Renzo-Olivares Renzo-Olivares Renzo-Olivares approved these changes

@LongCatIsLooong LongCatIsLooong Awaiting requested review from LongCatIsLooong

Assignees

@justinmc justinmc

Labels

a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@justinmc @christopherfujino @Renzo-Olivares