-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Widget-based MenuBar implementation #106581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79ba79c to
9fab2f6
Compare
9fab2f6 to
9dd883c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a: tests
"flutter test", flutter_test, or one of our tests
c: contributor-productivity
Team-specific productivity, code health, technical debt.
d: api docs
Issues with https://api.flutter.dev/
d: examples
Sample code and demos
f: material design
flutter/packages/flutter/material repository.
framework
flutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT PR
This is an alternative implementation of
MenuBarwhere the menus can be anyWidgetinstead of being required to haveMenuItemwidgets as menus.It allow including generic widgets with menu items, but it makes it almost impossible to implement groups (because they can't learn about their context), and it comes with some weird restrictions, like you can't wrap more than one menu item in a collection (
Column/Row/Flex, etc.), it can't do tab traversal for the entire tree (because it only sees a subset at a time), and you can't have menu items automatically define the menu shortcuts (because the widgets only exist when they're visible). The alternative is an implementation that only allows a subset of widgets (MenuItemsubclasses, whereMenuItemimplements Widget). It doesn't have any of the above limitations, but you can't just insert aTextinto the menu.