Skip to content

Fix typo in painting.TextStyle.merge docs #106511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
goderbauer merged 1 commit into from
Jul 6, 2022
Merged

Fix typo in painting.TextStyle.merge docs #106511

goderbauer merged 1 commit into from
Jul 6, 2022

Conversation

@Goddchen
Copy link
Contributor

@Goddchen Goddchen commented Jun 23, 2022 •
edited
Loading

Just fixing a small typo that annoys me everytime I see it 😉

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Jun 23, 2022
goderbauer
goderbauer approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you!

@goderbauer
Copy link
Member

goderbauer commented Jun 29, 2022

@snat-s Can you do a secondary review in this one?

@Goddchen
Copy link
Contributor Author

Goddchen commented Jun 30, 2022

What is up with this pending action "Google testing"? Do I have to do something about it?

snat-s
snat-s approved these changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@snat-s snat-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snat-s snat-s added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 1, 2022
@goderbauer goderbauer merged commit 084e252 into flutter:master Jul 6, 2022
This was referenced Jul 7, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2022
@engine-flutter-autoroll
084e252 Fix typo in painting.TextStyle.merge docs (flutter/flutter#10…
bbc88c4 
…6511)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 7, 2022
@engine-flutter-autoroll
084e252 Fix typo in painting.TextStyle.merge docs (flutter/flutter#10…
1a28d88 
…6511)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@Goddchen @camsim99
Fix typo in painting.TextStyle.merge docs (flutter#106511)
a95e9c2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
084e252 Fix typo in painting.TextStyle.merge docs (flutter/flutter#10…
e734f32 
…6511)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
084e252 Fix typo in painting.TextStyle.merge docs (flutter/flutter#10…
72c4e62 
…6511)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

+1 more reviewer

@snat-s snat-s snat-s approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Goddchen @goderbauer @snat-s