Skip to content

Fix typo in flutter_test binding.dart #106505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Jun 24, 2022
Merged

Fix typo in flutter_test binding.dart #106505

auto-submit merged 1 commit into from
Jun 24, 2022

Conversation

@bryanoltman
Copy link
Contributor

@bryanoltman bryanoltman commented Jun 23, 2022 •
edited
Loading

not force a frame her to give the test full -> do not force a frame here to give the test full

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Jun 23, 2022
jonahwilliams
jonahwilliams approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 24, 2022
@auto-submit auto-submit bot merged commit 6c3a0e4 into flutter:master Jun 24, 2022
This was referenced Jun 24, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 24, 2022
@engine-flutter-autoroll
6c3a0e4 Fix typo in flutter_test binding.dart (flutter/flutter#106505)
4310ad6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 24, 2022
@engine-flutter-autoroll
6c3a0e4 Fix typo in flutter_test binding.dart (flutter/flutter#106505)
551ddf1
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@bryanoltman @camsim99
Fix typo in flutter_test binding.dart (flutter#106505)
a0340a9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
6c3a0e4 Fix typo in flutter_test binding.dart (flutter/flutter#106505)
3a392e4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
6c3a0e4 Fix typo in flutter_test binding.dart (flutter/flutter#106505)
4b4fa18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bryanoltman @jonahwilliams