Skip to content

Conversation

@bleroux
Copy link
Contributor

@bleroux bleroux commented Jun 23, 2022

Description

This documentation PR adds several 'see also' sections in order to make WidgetController.timedDrag more discoverable.

Related Issue

Fixes #96893

Tests

No Test, documentation update only.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Jun 23, 2022
@bleroux bleroux requested a review from dkwingsmt June 23, 2022 13:29
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer
Copy link
Member

@loic-sharma Can you do a secondary review?

Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some bikeshedding on format. Otherwise good!

Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bleroux bleroux force-pushed the add_documentation_references_to_timed_drag branch from f3d0db0 to ff021e8 Compare June 30, 2022 11:07
@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 30, 2022
@auto-submit auto-submit bot merged commit 776a15c into flutter:master Jun 30, 2022
@bleroux bleroux deleted the add_documentation_references_to_timed_drag branch June 30, 2022 13:30
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 30, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 30, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 30, 2022
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReorderableListView weird onReorder behaviour in tests

4 participants