Apply PrimaryScrollController updates to SingleChildScrollView #106430
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the updates to PrimaryScrollController to SingleChildScrollView. It was left out in the original PR.
From original PR (#102099) for context:
This updates the PrimaryScrollController to not automatically attach to scroll views on desktop as it does on mobile platforms.
This behavior has caused a lot of issues for users developing desktop applications that have multiple parallel vertical ScrollViews.
This adds two parameters to PrimaryScrollController
automaticallyInheritForPlatformsscrollDirectionAlso adds static method
shouldInherit, which uses the two properties above to determine if automatically inheriting the ScrollController is appropriate for the current configuration.This design and other approaches is discussed at length in this design document.
Fixes #100264
Related (among others):
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
](https://github.com/Piinks/flutter/pull/new/fixSingleChild)