@yjbanov @danrubel I thought we had a benchmark that checked the time it takes to run the analyzer, but I don't see one any more. Before we check this in, can we make sure we have a cocoon benchmark that runs the following combinations and logs the times for each one?

• analyze --flutter-repo --benchmark
• analyze --flutter-repo --watch --benchmark
• analyze --benchmark for the gallery (or the mega gallery)
• analyze --watch --benchmark for the gallery (or the mega gallery)

(make sure to run rm ~/.dartServer before each of these so they don't interfere with each other)

I want to make sure we track the times for running analyses so that we don't regress them while unifying all our behaviours.

The patch itself looks great. LGTM.

@Hixie Adding cocoon tests makes good sense. Unfortunately I don't have the cycles at this point to do so.

Shouldn't be too hard, let me see what I can do.

Didn't get to it today, we had some fires to fight. But will look at it tomorrow between meetings. I'm pretty sure we have some already, just need to figure out why they're not running.

I believe the flutter analyze benchmarks were retired (at least the graphs were); @yjbanov to confirm.

I resurrected them a minute ago.

Now that Yegor has resurrected the necessary tests (thank you!), I'll wait until flutter-build is green, then commit. PLMK if that is not the appropriate course of action.

Sounds good, thanks! And thanks @yjbanov!

There's some redness now, but my commit was all green. https://flutter-dashboard.appspot.com/api/public/build-status (as of this typing) says you're good to go.

No significant movement in the benchmarks after this change:

That was just FYI. No action requested.