Skip to content

Export public API types from foundation/scheduler/gestures/semantics #106409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Jun 24, 2022
Merged

Export public API types from foundation/scheduler/gestures/semantics #106409

auto-submit merged 2 commits into from
Jun 24, 2022

Conversation

@a14n
Copy link
Contributor

@a14n a14n commented Jun 22, 2022

Related to dart-lang/sdk#58731 this PR exports public API types from foundation/scheduler/gestures/semantics libraries.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems f: focus Focus traversal, gaining or losing focus f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Jun 22, 2022
@a14n a14n force-pushed the export_public_api_types_2 branch from cf5be30 to adb8487 Compare June 22, 2022 14:04
@a14n a14n marked this pull request as ready for review June 22, 2022 14:50
@a14n a14n requested a review from Hixie June 24, 2022 20:59
Hixie
Hixie approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a14n a14n added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 24, 2022
@auto-submit auto-submit bot merged commit 526ca0d into flutter:master Jun 24, 2022
@a14n a14n deleted the export_public_api_types_2 branch June 25, 2022 11:55
This was referenced Jun 25, 2022
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 25, 2022
@engine-flutter-autoroll
526ca0d Export public API types from foundation/scheduler/gestures/se…
006c9a5 
…mantics (flutter/flutter#106409)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2022
@engine-flutter-autoroll
526ca0d Export public API types from foundation/scheduler/gestures/se…
db34a8c 
…mantics (flutter/flutter#106409)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 26, 2022
@engine-flutter-autoroll
526ca0d Export public API types from foundation/scheduler/gestures/se…
b077d70 
…mantics (flutter/flutter#106409)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 27, 2022
@engine-flutter-autoroll
526ca0d Export public API types from foundation/scheduler/gestures/se…
93f63c0 
…mantics (flutter/flutter#106409)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 27, 2022
@engine-flutter-autoroll
526ca0d Export public API types from foundation/scheduler/gestures/se…
497006b 
…mantics (flutter/flutter#106409)
@Hixie
Copy link
Contributor

Hixie commented Jun 27, 2022

526ca0d#r77107670

We should re-export SpellOutStringAttribute (and maybe LocaleStringAttribute) from lib/semantics.dart.

@Hixie
Copy link
Contributor

Hixie commented Jun 27, 2022

i'll submit a pr

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 27, 2022
@engine-flutter-autoroll
526ca0d Export public API types from foundation/scheduler/gestures/se…
a1aa294 
…mantics (flutter/flutter#106409)
@Hixie
Copy link
Contributor

Hixie commented Jun 27, 2022

#106682

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 28, 2022
@engine-flutter-autoroll
526ca0d Export public API types from foundation/scheduler/gestures/se…
bb78502 
…mantics (flutter/flutter#106409)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 28, 2022
@engine-flutter-autoroll
526ca0d Export public API types from foundation/scheduler/gestures/se…
1c2d662 
…mantics (flutter/flutter#106409)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 28, 2022
@engine-flutter-autoroll
526ca0d Export public API types from foundation/scheduler/gestures/se…
6d7d55e 
…mantics (flutter/flutter#106409)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 28, 2022
@engine-flutter-autoroll
526ca0d Export public API types from foundation/scheduler/gestures/se…
71efe83 
…mantics (flutter/flutter#106409)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 28, 2022
@engine-flutter-autoroll
526ca0d Export public API types from foundation/scheduler/gestures/se…
3a07262 
…mantics (flutter/flutter#106409)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@a14n @camsim99
Export public API types from foundation/scheduler/gestures/semantics (f…
b1be778 
…lutter#106409)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
526ca0d Export public API types from foundation/scheduler/gestures/se…
6c7829e 
…mantics (flutter/flutter#106409)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
526ca0d Export public API types from foundation/scheduler/gestures/se…
dfd91ed 
…mantics (flutter/flutter#106409)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hixie Hixie Hixie approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: focus Focus traversal, gaining or losing focus f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@a14n @Hixie