Skip to content

Chip theme cleanup #106384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
darrenaustin merged 1 commit into from
Jun 22, 2022
Merged

Chip theme cleanup #106384

darrenaustin merged 1 commit into from
Jun 22, 2022

Conversation

@darrenaustin
Copy link
Contributor

@darrenaustin darrenaustin commented Jun 22, 2022 •
edited
Loading

Various small cleanups of the Chip theme:

  • ChipThemeData.showCheckmark was missing from several of the standard theme APIs (like copyWith).
  • Added more properties to ChipTheme.fromDefaults.
  • Improved the tests for ChipThemeData.
  • Removed checking ThemeData.chipTheme in the build method as it is already handled by ChipTheme.of().

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@darrenaustin
Chip theme cleanup
a5a34d7 
- Added complete support for showCheckmark to ChipThemeData.
- Removed build method checks for ThemeData.chipTheme, as that is
  already handled by ChipTheme.of().
@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 22, 2022
@darrenaustin darrenaustin requested a review from HansMuller June 22, 2022 01:40
HansMuller
HansMuller approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TahaTesser TahaTesser mentioned this pull request Jun 22, 2022
Closed
8 tasks
@darrenaustin darrenaustin merged commit c8f867b into flutter:master Jun 22, 2022
@darrenaustin darrenaustin deleted the chip_theme_cleanup branch June 22, 2022 07:16
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 22, 2022
@engine-flutter-autoroll
c8f867b Chip theme cleanup (flutter/flutter#106384)
8a67628
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 22, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 22, 2022
@engine-flutter-autoroll
c8f867b Chip theme cleanup (flutter/flutter#106384)
75ddc54
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 22, 2022
@engine-flutter-autoroll
c8f867b Chip theme cleanup (flutter/flutter#106384)
4210b76
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 22, 2022
@engine-flutter-autoroll
c8f867b Chip theme cleanup (flutter/flutter#106384)
18cf6d6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 22, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 22, 2022
@engine-flutter-autoroll
c8f867b Chip theme cleanup (flutter/flutter#106384)
e908fb4
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@darrenaustin @camsim99
Chip theme cleanup (flutter#106384)
0226bc9 
- Added complete support for showCheckmark to ChipThemeData.
- Removed build method checks for ThemeData.chipTheme, as that is
  already handled by ChipTheme.of().
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
c8f867b Chip theme cleanup (flutter/flutter#106384)
29f6964
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
c8f867b Chip theme cleanup (flutter/flutter#106384)
6192816
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@darrenaustin @HansMuller