-
Notifications
You must be signed in to change notification settings - Fork 29.7k
[framework] remove opacity layer at fully opaque #106351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[framework] remove opacity layer at fully opaque #106351
Conversation
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Won't this introduce pixel snapping on mobile? Can/should this wait until mobile has opted into fractional translation? |
|
It will be extremely minor, we never noticed the issue until we added desktop targets. We can definitely wait, but there is still a chance we won't be able to remove pixel snapping from mobile yet - in which case it would be a shame to lose this. |
dnfield
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Supposidly this reduced the new gen gc count on an opacity benchmak, though that is an odd improvement: |
|
Benchmark looks noisy - it usually gets 2 gcs but sometimes gets zero. |
|
Probably an acceptable level of noise though, those benchmarks were really designed to capture going from 10s or 100s of GCs to much fewer. |
Fixes #105408
Now that google3 tests do not pixel snap, we can drop this layer at fully opaque. This will not cause rendering problems on desktop since FRACTIONAL_TRANSLATION is enabled now.
This will also reduce the amount of compositing in the customer money app (marginally)
See also: #103909