Skip to content

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Jun 21, 2022

Fixes #105408

Now that google3 tests do not pixel snap, we can drop this layer at fully opaque. This will not cause rendering problems on desktop since FRACTIONAL_TRANSLATION is enabled now.

This will also reduce the amount of compositing in the customer money app (marginally)

See also: #103909

@flutter-dashboard flutter-dashboard bot added f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Jun 21, 2022
@jonahwilliams jonahwilliams requested a review from dnfield June 21, 2022 17:15
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #106351 at sha 9e848e8

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Jun 21, 2022
@dnfield
Copy link
Contributor

dnfield commented Jun 21, 2022

Won't this introduce pixel snapping on mobile?

Can/should this wait until mobile has opted into fractional translation?

@jonahwilliams
Copy link
Contributor Author

It will be extremely minor, we never noticed the issue until we added desktop targets. We can definitely wait, but there is still a chance we won't be able to remove pixel snapping from mobile yet - in which case it would be a shame to lose this.

Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams merged commit c12b0de into flutter:master Jun 21, 2022
@jonahwilliams jonahwilliams deleted the remove_animated_opacity branch June 21, 2022 18:05
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 21, 2022
@jonahwilliams
Copy link
Contributor Author

@dnfield
Copy link
Contributor

dnfield commented Jun 21, 2022

Benchmark looks noisy - it usually gets 2 gcs but sometimes gets zero.

@dnfield
Copy link
Contributor

dnfield commented Jun 21, 2022

Probably an acceptable level of noise though, those benchmarks were really designed to capture going from 10s or 100s of GCs to much fewer.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 22, 2022
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove forced compositing from paused/completed FadeTransition

2 participants