Skip to content

Fix ListTile theme shape in a drawer #106343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
darrenaustin merged 3 commits into from
Jul 8, 2022
Merged

Fix ListTile theme shape in a drawer #106343

darrenaustin merged 3 commits into from
Jul 8, 2022

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Jun 21, 2022

fixes #106303

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 21, 2022
@HansMuller HansMuller requested a review from darrenaustin July 1, 2022 21:45
darrenaustin
darrenaustin suggested changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TahaTesser thanks for the fix. The approach you use here would make the ListTile handle its theme data differently than all the other widgets. I have a suggestion below that I think would be a better fix for this.

@TahaTesser TahaTesser force-pushed the fix_list_tile_theme_shape branch from 5626500 to c4c52de Compare July 4, 2022 07:37
@TahaTesser TahaTesser requested a review from darrenaustin July 4, 2022 08:06
darrenaustin
darrenaustin suggested changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor change, and I think we are good to go. Thx.

@TahaTesser TahaTesser requested a review from darrenaustin July 8, 2022 12:13
darrenaustin
darrenaustin approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thx!

@darrenaustin darrenaustin merged commit 750516a into flutter:master Jul 8, 2022
@TahaTesser TahaTesser deleted the fix_list_tile_theme_shape branch July 8, 2022 18:11
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 8, 2022
@engine-flutter-autoroll
750516a Fix ListTile theme shape in a drawer (flutter/flutter#106343)
a62cf54
This was referenced Jul 9, 2022
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 9, 2022
@engine-flutter-autoroll
750516a Fix ListTile theme shape in a drawer (flutter/flutter#106343)
4c5e889
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 9, 2022
@engine-flutter-autoroll
750516a Fix ListTile theme shape in a drawer (flutter/flutter#106343)
17410ac
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 9, 2022
@engine-flutter-autoroll
750516a Fix ListTile theme shape in a drawer (flutter/flutter#106343)
e5efb9a
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@TahaTesser @camsim99
Fix ListTile theme shape in a drawer (flutter#106343)
52dc7ad
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
750516a Fix ListTile theme shape in a drawer (flutter/flutter#106343)
fd712b6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
750516a Fix ListTile theme shape in a drawer (flutter/flutter#106343)
cd34a54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@darrenaustin darrenaustin darrenaustin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ListTileTheme not respected in a scaffold's drawer option

2 participants

@TahaTesser @darrenaustin