Skip to content

Conversation

@a14n
Copy link
Contributor

@a14n a14n commented Jun 20, 2022

Related to dart-lang/sdk#58731 this PR exports public API types from services/*.dart library.

Before this PR the namespace export by gesture.dart was (outside of services):

  • export 'dart:typed_data' show ByteData;
  • export 'dart:ui' show Brightness, TextAffinity, TextPosition, TextRange;

After this PR:

  • export 'dart:typed_data' show ByteData, Uint8List;
  • export 'dart:ui' show Brightness, Color, FontWeight, ImmutableBuffer, KeyData, Offset, PlatformMessageResponseCallback, Rect, Size, TextAlign, TextAffinity, TextDirection, TextPosition, TextRange, VoidCallback;
  • export 'package:flutter/foundation.dart' show DiagnosticLevel, DiagnosticPropertiesBuilder, ReadBuffer, TargetPlatform, ValueChanged, WriteBuffer;
  • export 'package:flutter/gestures.dart' show PointerEnterEvent, PointerEvent, PointerExitEvent;
  • export 'package:vector_math/vector_math_64.dart' show Matrix4;

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jun 20, 2022
@a14n a14n force-pushed the export_public_api_types branch from deabe03 to 2b72c65 Compare June 21, 2022 06:52
@a14n a14n force-pushed the export_public_api_types branch from 6073a5b to 12c2392 Compare June 25, 2022 12:44
@a14n a14n force-pushed the export_public_api_types branch from 12c2392 to ca63a6a Compare June 28, 2022 16:11
@a14n a14n force-pushed the export_public_api_types branch from ca63a6a to b990fb8 Compare June 28, 2022 19:46
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-exempt: code refactor with no semantic change

@a14n a14n added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 28, 2022
@auto-submit auto-submit bot merged commit bbdf617 into flutter:master Jun 28, 2022
@a14n a14n deleted the export_public_api_types branch June 28, 2022 20:27
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 28, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2022
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants