[Reland]: Fix StretchingOverscrollIndicator clipping and add clipBehavior parameter
#106287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
Piinks
reviewed
Jun 22, 2022
Comment on lines
269
to
270
Contributor
There was a problem hiding this comment.
Suggested change
| /// Rather than clipping [Scrollable], this is passed to decorators in | |
| /// [ScrollableDetails]. | |
| /// This is passed to decorators in [ScrollableDetails], and does not directly affect | |
| /// clipping of the Scrollable. This reflects the same [Clip] that is provided | |
| // to [ScrollView.clipBehavior] and is supplied to the [Viewport]. |
Contributor
There was a problem hiding this comment.
Why is it nullable if the docs say it cannot be?
Member
Author
There was a problem hiding this comment.
Forgot to update this, thanks!
TahaTesser
force-pushed
the
reland_overscroll_clip_behavior
branch
from
360a497 to
7c2afbf
Compare
Piinks
reviewed
Jun 28, 2022
Contributor
There was a problem hiding this comment.
Oh I think the wrong docs were updated. Just a mix up nit. 🙃
Member
Author
There was a problem hiding this comment.
My bad. (messed up search and fix)
TahaTesser
force-pushed
the
reland_overscroll_clip_behavior
branch
from
eabfc21 to
81b7d85
Compare
TahaTesser
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 30, 2022
…d `clipBehavior` parameter (flutter/flutter#106287)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 30, 2022
…d `clipBehavior` parameter (flutter/flutter#106287)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 30, 2022
…d `clipBehavior` parameter (flutter/flutter#106287)
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
…ehavior` parameter (flutter#106287)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
…d `clipBehavior` parameter (flutter/flutter#106287)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
…d `clipBehavior` parameter (flutter/flutter#106287)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reland #105303 with minor tweaks.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.