Mark use of deprecated type. #106282
Mark use of deprecated type. #106282
Conversation
`NullThrownError` will be deprecated Real Soon Now (https://dart-review.googlesource.com/c/sdk/+/248901) since it isn't needed in sound null-safe code, and therefore should go away when support is dropped for unsound/pre null-safe code. Missed this use in prior PR.
flutter-dashboard
bot
added
the
framework
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@Hixie |
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
Reaching out to Hixie for test exemption.
|
test-exempt: is a test |
3 participants
NullThrownErrorwill be deprecated Real Soon Now (https://dart-review.googlesource.com/c/sdk/+/248901) since it isn't needed in sound null-safe code, and therefore should go away when support is dropped for unsound/pre null-safe code.Missed this use in prior PR.