Change "Unicode scalar values" to "Unicode grapheme clusters" in maxLength docs #106275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: text input
LongCatIsLooong
approved these changes
Aug 16, 2022
Contributor
LongCatIsLooong
left a comment
LongCatIsLooong
left a comment
There was a problem hiding this comment.
LGTM. @gspencergoog would you like to take a look?
gspencergoog
approved these changes
Aug 16, 2022
Contributor
gspencergoog
left a comment
gspencergoog
left a comment
There was a problem hiding this comment.
Thanks for changing that, I'm sure it was an oversight when we migrated. It used to be the case that they were scalar values (before Dart had support for grapheme clusters), but we have integrated the Characters class and now the character count truly are grapheme clusters.
LongCatIsLooong
added
the
autosubmit
This was referenced Aug 17, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2022
… in maxLength docs (flutter/flutter#106275)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 17, 2022
… in maxLength docs (flutter/flutter#106275)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current documentation for TextField.maxLength and CupertinoTextField.maxLength suggests that 'character' means "Unicode scalar value", but this is not actually what 'character' means in this context. As described explicitly a little further down on the doc page, and on the page for LengthLimitingTextInputFormatter.maxLength, multiple Unicode scalar values can combine to form one user-perceived character.
This PR corrects the documentation by changing "Unicode scalar values" to "Unicode grapheme clusters", as described in the characters package documentation.
I haven't created a separate issue for this minor docs change; happy to file one if needed.
cc @gspencergoog (as the person git suggests worked on this)
Pre-launch Checklist
I listed at least one issue that this PR fixes in the description above.Hopefully N/A.///).