Skip to content

[docs] fix typos in page_transitions_theme.dart and tooltip.dart #106264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Jun 21, 2022
Merged

[docs] fix typos in page_transitions_theme.dart and tooltip.dart #106264

auto-submit merged 2 commits into from
Jun 21, 2022

Conversation

@albinpk
Copy link
Contributor

@albinpk albinpk commented Jun 19, 2022 •
edited
Loading

  • Remove a repeated word in packages/flutter/lib/src/material/page_transitions_theme.dart
  • Fix typo in packages/flutter/lib/src/material/tooltip.dart

Fix #106263

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 19, 2022
@google-cla
Copy link

google-cla bot commented Jun 19, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@albinpk albinpk force-pushed the albinpk-patch-1 branch 2 times, most recently from 866992b to 4ff461c Compare June 20, 2022 15:25
@albinpk albinpk changed the title [docs] update page_transitions_theme.dart [docs] fix typos in page_transitions_theme.dart and tooltip.dart Jun 20, 2022
abinvs-2019 pushed a commit to abinvs-2019/flutter that referenced this pull request Jun 21, 2022
Fix (flutter#106264)
c68bd8b
abinvs-2019
abinvs-2019 reviewed Jun 21, 2022
View reviewed changes
Copy link

@abinvs-2019 abinvs-2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed typos in page page_transitions_theme.dart and tooltip.dart.

@TahaTesser TahaTesser self-requested a review June 21, 2022 14:30
@TahaTesser
Copy link
Member

TahaTesser commented Jun 21, 2022

Before this can be merged this need a test exemption and second review from @Hixie

@TahaTesser TahaTesser requested a review from Hixie June 21, 2022 14:36
@Piinks Piinks added d: api docs Issues with https://api.flutter.dev/ documentation labels Jun 21, 2022
Piinks
Piinks approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM
Thanks!

@Hixie Hixie added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 21, 2022
@auto-submit auto-submit bot merged commit b5c0f8a into flutter:master Jun 21, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 21, 2022
@engine-flutter-autoroll
b5c0f8a [docs] fix typos in page_transitions_theme.dart and tooltip.d…
3c53d91 
…art (flutter/flutter#106264)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 21, 2022
@engine-flutter-autoroll
b5c0f8a [docs] fix typos in page_transitions_theme.dart and tooltip.d…
84dc401 
…art (flutter/flutter#106264)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 22, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 22, 2022
@engine-flutter-autoroll
b5c0f8a [docs] fix typos in page_transitions_theme.dart and tooltip.d…
03ad5ad 
…art (flutter/flutter#106264)
@albinpk
Copy link
Contributor Author

albinpk commented Jun 23, 2022

Thanks ❤️

@albinpk albinpk deleted the albinpk-patch-1 branch June 23, 2022 13:53
@HansMuller HansMuller mentioned this pull request Jun 23, 2022
Closed
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@albinpk @camsim99
[docs] fix typos in page_transitions_theme.dart and tooltip.dart (flu…
eb3efe4 
…tter#106264)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
b5c0f8a [docs] fix typos in page_transitions_theme.dart and tooltip.d…
8d75643 
…art (flutter/flutter#106264)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
b5c0f8a [docs] fix typos in page_transitions_theme.dart and tooltip.d…
f128251 
…art (flutter/flutter#106264)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

@TahaTesser TahaTesser TahaTesser approved these changes

@Hixie Hixie Awaiting requested review from Hixie

+1 more reviewer

@abinvs-2019 abinvs-2019 abinvs-2019 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[docs] word repeated in page_transitions_theme.dart docs

5 participants

@albinpk @TahaTesser @Piinks @abinvs-2019 @Hixie