[flutter_tools] tool exit access denied during symlinking #106213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
christopherfujino
changed the title
christopherfujino
force-pushed
the
tool-exit-on-errno-5-during-symlink
branch
from
7aef7bd to
8d8d42e
Compare
Jasguerrero
reviewed
Jun 17, 2022
|
|
||
| expect(() => handleSymlinkException(e, platform: platform, os: os), returnsNormally); | ||
| expect( | ||
| () => handleSymlinkException( |
Contributor
There was a problem hiding this comment.
Can you add 2 more tests that hits this two different instructions? final String instructions = (version != null && version >= Version(10, 0, 14972)) .... Or let me know if I am reading this tests wrong and you are already catching that
Contributor
Author
There was a problem hiding this comment.
I didn't really update this behavior or test, I just updated the function signature and made the fields required (the only real new test here is Symlink ERROR_ACCESS_DENIED failures show developers paths that were used.
Note the test on line 1614 covers newer windows versions.
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
This was referenced Jun 24, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 24, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 24, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96568
Throw a tool exit with paths to the where symlinking from and to (most likely the pubcache doesn't have read permissions).