Refactoring the setPubRootDirectory tests #106197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

CoderDake merged 14 commits into flutter:master from CoderDake:pubRootTestPrep

Jun 22, 2022

Contributor

CoderDake commented Jun 17, 2022

This is a small refactor to the specs that test setPubRootDirectories in the widget_inspector. These changes to the setPubRootTests will make the upcoming PR for #105730 a bit clearer, since the pubRoot tests will be modified to accommodate the new interactions.

In preparation for #105730

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

CoderDake requested a review from jacob314

June 17, 2022 14:28

flutter-dashboard bot added the framework label

CoderDake changed the title ~~Pub root test prep~~ Refactoring the setPubRootDirectory Tests

CoderDake changed the title ~~Refactoring the setPubRootDirectory Tests~~ Refactoring the setPubRootDirectory tests

HansMuller added f: inspector and removed framework labels

jacob314 reviewed

View reviewed changes

packages/flutter/test/widgets/widget_inspector_test.dart Outdated Show resolved Hide resolved

jacob314 reviewed

View reviewed changes

packages/flutter/test/widgets/widget_inspector_test.dart Outdated Show resolved Hide resolved

jacob314 reviewed

View reviewed changes

packages/flutter/test/widgets/widget_inspector_test.dart Outdated Show resolved Hide resolved

jacob314 reviewed

View reviewed changes

packages/flutter/test/widgets/widget_inspector_test.dart Outdated Show resolved Hide resolved

jacob314 reviewed

View reviewed changes

Contributor

jacob314 left a comment

Looks like good test cleanup refactoring overall. A few small comments on how to make it cleaner.

jacob314 reviewed

View reviewed changes

packages/flutter/test/widgets/widget_inspector_test.dart Outdated Show resolved Hide resolved

jacob314 approved these changes

View reviewed changes

Contributor

jacob314 left a comment

with dartfmt nit.

CoderDake marked this pull request as ready for review

June 21, 2022 17:53

CoderDake added 14 commits

June 22, 2022 14:04


          first blush

731a61c


          remove the test for diffing

c45bdc8


          last couple changes

b68f230


          much cleaner pubRootTest

e18f68d


          address jacob comments

09fbdea


          phase 2 :D

b07ff5c


          Phase 3

2b8aeef


          some formatting

5e7b420


          dart fmt!

d039320


           fix tests (Oops extra import)

723e70b


          learned about cirrus

6f12e15


          oops accidentally deleted bracket

6d2e192


          move intended to skip line

02e26d0


          trailing space

859ec4a

CoderDake force-pushed the pubRootTestPrep branch from 61b0aa4 to 859ec4a Compare

June 22, 2022 18:05

CoderDake merged commit 8ff6911 into flutter:master

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 60f30e5d3ed4 to a30012b27505 (8 revisions) flutter/plugins#6033

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request


          8ff6911 Refactoring the setPubRootDirectory tests (flutter/flutter#10…

91c3f9e

…6197)

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 2540547f06d6 to a30012b27505 (11 revisions) flutter/packages#2273

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          8ff6911 Refactoring the setPubRootDirectory tests (flutter/flutter#10…

af4967b

…6197)

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 2540547f06d6 to fe41b6abcd53 (12 revisions) flutter/packages#2274

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          8ff6911 Refactoring the setPubRootDirectory tests (flutter/flutter#10…

0dd1b26

…6197)

camsim99 pushed a commit to camsim99/flutter that referenced this pull request


          Refactoring the setPubRootDirectory tests (flutter#106197)

ecc5626

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          8ff6911 Refactoring the setPubRootDirectory tests (flutter/flutter#10…

c488de4

…6197)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request


          8ff6911 Refactoring the setPubRootDirectory tests (flutter/flutter#10…

13d328b

…6197)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels