Modify iOS template to fit Apple's HIG #106111
Conversation
flutter-dashboard
bot
added
the
tool
|
Excited about this PR! |
Yes, I've seen it. I thought Android and iOS were different from other platforms. 😂 I'll try to modify. |
|
Currently they are different only because the current icons predate the new out-of-repo system. |
|
@timsneath I have created a new PR flutter/packages#2266 |
|
From tools triage meeting: this PR is pending flutter/packages#2266 landing |
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
The test case I was mentioned in flutter/packages#2266 (review) would be something like:
flutter/packages/flutter_tools/test/commands.shard/permeable/create_test.dart
Lines 154 to 163 in 0e0baa4
<String>[
'analysis_options.yaml',
'android/app/src/main/java/com/example/flutter_project/MainActivity.java',
'android/app/src/main/java/io/flutter/plugins/GeneratedPluginRegistrant.java',
'flutter_project.iml',
'ios/Flutter/AppFrameworkInfo.plist',
'ios/Runner/AppDelegate.m',
'ios/Runner/GeneratedPluginRegistrant.h',
+ 'ios/Runner/Assets.xcassets/AppIcon.appiconset/[email protected]',
'lib/main.dart',
], That test creates a flutter app, and validates those files exist in the newly created app. So validate that at least one of your templated icons gets downloaded and put in the right spot.
|
And flutter/packages#2266 is now published. Probably easiest to rebase/merged your branch to top of tree to kick all those tests again. |
I apologize for only seeing it now. Do I need to submit a pull request to flutter/packages for this test? |
|
That test is part of this repository, so should be in this PR. |
|
@RockerFlower are you ready to fix this up and merge? This is blocking any further updates to |
Apologies, I didn't notice you had just commented on this PR! Coincidently I thought "hm wonder if that merged" and opened this up, before I read my GitHub notifications. 🤦♀️ |
Updates the AppIcon and LaunchImage assets in the iOS app template to meet Apple's icon guidelines as of iOS. Assets were moved to the [flutter_template_images][1] package, which includes them as of version 4.2.0. Ref: https://developer.apple.com/design/human-interface-guidelines/foundations/app-icons#specifications Update the test on creating iOS templated icons Validate that at least one of the iOS templated icons gets downloaded and put in the right spot. Issue: flutter#106110 [1]: https://github.com/flutter/packages/tree/main/packages/flutter_template_images
I recommitted it, but there are still some failures in the automated checks. |
|
It looks unrelated to your actual changes, you're branched from e1d9adf which is pretty old, can you rebase or merge onto master top of tree? I would just do it for you on your fork if I had permission but this PR is on your main branch and I don't want to mess with that. |
This reverts commit a693b5e.
Updates the AppIcon and LaunchImage assets in the iOS app template to meet Apple's icon guidelines as of iOS. Assets were moved to the [flutter_template_images][1] package, which includes them as of version 4.2.0. Ref: https://developer.apple.com/design/human-interface-guidelines/foundations/app-icons#specifications Update the test on creating iOS templated icons Validate that at least one of the iOS templated icons gets downloaded and put in the right spot. Issue: flutter#106110 [1]: https://github.com/flutter/packages/tree/main/packages/flutter_template_images
|
The relevant changes have been merged here: #107873 |
5 participants
Scale down
[email protected]to different sizes and replace the original icon with rounded corners.fix #106110
This is how the application icons are displayed in the settings list, obviously with black gaps in the four corners. This is because the mask Apple uses is not the standard rounded corners, but continuous corner.
This is a slow motion video of the app when it is opened from the home screen. The black color in the transition animation is caused by the transparent part of the icon.
This animation takes the colors of the left, bottom and right sides of the icon and then spreads the colors in all three directions, but the current icon has rounded corners, so some of the colors are missing.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.