Skip to content

Add integration test for flutter build windows #106053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
loic-sharma merged 4 commits into from
Jun 18, 2022
Merged

Add integration test for flutter build windows #106053

loic-sharma merged 4 commits into from
Jun 18, 2022

Conversation

@loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented Jun 15, 2022 •
edited
Loading

Add an integration test that verifies that flutter build windows produces the expected executable. In the future, this will be used to test that version information is properly stamped on the executable.

This solution uses PowerShell to read the executable's version information. I chose against using win32's version APIs as that requires adding package:ffi and >100 lines of FFI boilerplate.

Part of #73652.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 15, 2022
loic-sharma
loic-sharma commented Jun 15, 2022
View reviewed changes
packages/flutter_tools/test/integration.shard/flutter_build_windows_test.dart Outdated
Copy link
Member Author

@loic-sharma loic-sharma Jun 15, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not ideal. Since Flutter's builder number defaults to 1, ideally the default file version would be 1.0.0.1. I'll fix this in a subsequent pull request.

@loic-sharma loic-sharma force-pushed the add_build_windows_integration_test branch from 032facb to 87581bb Compare June 16, 2022 20:31
@loic-sharma loic-sharma mentioned this pull request Jun 16, 2022
Merged
8 tasks
cbracken
cbracken approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo nits.

@loic-sharma loic-sharma merged commit 2efa2e4 into flutter:master Jun 18, 2022
@loic-sharma loic-sharma deleted the add_build_windows_integration_test branch June 18, 2022 00:14
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2022
@engine-flutter-autoroll
2efa2e4 Add integration test for flutter build windows (flutter/flu…
43781a8 
…tter#106053)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 18, 2022
@engine-flutter-autoroll
2efa2e4 Add integration test for flutter build windows (flutter/flu…
b4d1aaf 
…tter#106053)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 19, 2022
@engine-flutter-autoroll
2efa2e4 Add integration test for flutter build windows (flutter/flu…
23d5ab0 
…tter#106053)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 20, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 20, 2022
@engine-flutter-autoroll
2efa2e4 Add integration test for flutter build windows (flutter/flu…
44c4454 
…tter#106053)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 20, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 20, 2022
@engine-flutter-autoroll
2efa2e4 Add integration test for flutter build windows (flutter/flu…
a1d6781 
…tter#106053)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 20, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 20, 2022
@engine-flutter-autoroll
2efa2e4 Add integration test for flutter build windows (flutter/flu…
483ee34 
…tter#106053)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 21, 2022
@engine-flutter-autoroll
2efa2e4 Add integration test for flutter build windows (flutter/flu…
a8c7447 
…tter#106053)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 21, 2022
@engine-flutter-autoroll
2efa2e4 Add integration test for flutter build windows (flutter/flu…
245d347 
…tter#106053)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 21, 2022
@engine-flutter-autoroll
2efa2e4 Add integration test for flutter build windows (flutter/flu…
92871b5 
…tter#106053)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@loic-sharma @camsim99
Add integration test for flutter build windows (flutter#106053)
a2d3b0c 
Add an integration test that verifies that `flutter build windows` produces the expected executable. In the future, this will be used to test that version information is properly stamped on the executable.

Part of flutter#73652.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
2efa2e4 Add integration test for flutter build windows (flutter/flu…
3fb7279 
…tter#106053)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
2efa2e4 Add integration test for flutter build windows (flutter/flu…
3128609 
…tter#106053)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbracken cbracken cbracken approved these changes

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

@gspencergoog gspencergoog Awaiting requested review from gspencergoog

+1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@loic-sharma @cbracken @jonahwilliams