Add indicatorWeight, indicatorPadding to TabBar #10600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Hixie
reviewed
Jun 9, 2017
| this.unselectedLabelStyle, | ||
| }) : assert(tabs != null && tabs.length > 1), | ||
| assert(isScrollable != null), | ||
| assert(indicatorWeight > 0.0), |
Hixie
reviewed
Jun 9, 2017
| TabBar({ | ||
| Key key, | ||
| @required this.tabs, | ||
| this.controller, |
Contributor
There was a problem hiding this comment.
constructor docs should be updated to list what shouldn't be null, etc.
Hixie
reviewed
Jun 9, 2017
| final List<double> offsets = _indicatorPainter?.tabOffsets; | ||
| _indicatorPainter = new _IndicatorPainter(_controller)..tabOffsets = offsets; | ||
| _indicatorPainter = new _IndicatorPainter(_controller, widget.indicatorWeight, widget.indicatorPadding) | ||
| ..tabOffsets = offsets; |
Contributor
There was a problem hiding this comment.
Why aren't the tab offsets passed in as an argument?
Contributor
|
LGTM except for the part where you mutate the state of the painter. All the mutable state should be private, and all the configuration should come in through the constructor. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable customizing the selected tab indicator line's weight and how far it's padded on the left and right vis the selected tab's bounds.
Fixes #10475