Skip to content

Allow DoNothingIntent and DoNothingAndStopPropagationIntent to be used in a const environment #105983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 5 commits into from
Jun 15, 2022
Merged

Allow DoNothingIntent and DoNothingAndStopPropagationIntent to be used in a const environment #105983

fluttergithubbot merged 5 commits into from
Jun 15, 2022

Conversation

@dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Jun 14, 2022 •
edited
Loading

This PR makes the factory constructors of DoNothingIntent and DoNothingAndStopPropagationIntent const.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Jun 14, 2022
@dkwingsmt dkwingsmt marked this pull request as ready for review June 14, 2022 22:40
@dkwingsmt dkwingsmt requested a review from gspencergoog June 14, 2022 22:41
@jonahwilliams
Copy link
Contributor

jonahwilliams commented Jun 14, 2022

You could something like:

class Foo {
  const factory Foo() = Foo._;
  
  
  const Foo._();
}

Then you don't need instance

@dkwingsmt
Copy link
Contributor Author

dkwingsmt commented Jun 14, 2022

I honestly didn't know that was a thing. Learning something everyday!

@dkwingsmt dkwingsmt requested a review from jonahwilliams June 14, 2022 22:59
gspencergoog
gspencergoog approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@fluttergithubbot fluttergithubbot merged commit e55aa0e into flutter:master Jun 15, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
e55aa0e Allow DoNothingIntent and DoNothingAndStopPropagationIntent t…
dedcd5a 
…o be used in a const environment (flutter/flutter#105983)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
e55aa0e Allow DoNothingIntent and DoNothingAndStopPropagationIntent t…
85ffce7 
…o be used in a const environment (flutter/flutter#105983)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@dkwingsmt @camsim99
Allow DoNothingIntent and DoNothingAndStopPropagationIntent to be use…
461e1f3 
…d in a const environment (flutter#105983)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
e55aa0e Allow DoNothingIntent and DoNothingAndStopPropagationIntent t…
9122f4b 
…o be used in a const environment (flutter/flutter#105983)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
e55aa0e Allow DoNothingIntent and DoNothingAndStopPropagationIntent t…
ebd8925 
…o be used in a const environment (flutter/flutter#105983)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dkwingsmt @jonahwilliams @gspencergoog @fluttergithubbot