Skip to content

Conversation

@alexmarkov
Copy link
Contributor

This change restores expectations for dev/automated_tests/flutter_test/exception_handling_test. In addition to testing the real stack traces, this test also verifies Chain captured using package:stack_trace. Due to a bug in Dart SDK, Chain from package:stack_trace was sometimes truncated.

The bug was fixed (dart-lang/sdk@e505ab1) and the fix was rolled into Flutter, so now we can restore the test expectations.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jun 10, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@alexmarkov alexmarkov marked this pull request as draft June 10, 2022 14:47
@flutter-dashboard
Copy link

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@alexmarkov alexmarkov marked this pull request as ready for review June 10, 2022 15:37
@alexmarkov alexmarkov requested review from gaaclarke and zanderso June 10, 2022 15:38
@zanderso zanderso requested a review from jason-simmons June 10, 2022 15:39
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Mac_android run_release_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Windows build_tests_1_3 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@alexmarkov alexmarkov merged commit 0cd8f3d into flutter:master Jun 14, 2022
@alexmarkov alexmarkov deleted the restore-stack-trace-expectations branch June 14, 2022 14:56
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants