-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Restore expectations for flutter_test/exception_handling_test #105778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore expectations for flutter_test/exception_handling_test #105778
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This pull request is not suitable for automatic merging in its current state.
|
…eption_handling_test (flutter/flutter#105778)
…eption_handling_test (flutter/flutter#105778)
…eption_handling_test (flutter/flutter#105778)
…eption_handling_test (flutter/flutter#105778)
…eption_handling_test (flutter/flutter#105778)
…eption_handling_test (flutter/flutter#105778)
This change restores expectations for
dev/automated_tests/flutter_test/exception_handling_test. In addition to testing the real stack traces, this test also verifiesChaincaptured usingpackage:stack_trace. Due to a bug in Dart SDK,Chainfrompackage:stack_tracewas sometimes truncated.The bug was fixed (dart-lang/sdk@e505ab1) and the fix was rolled into Flutter, so now we can restore the test expectations.