Skip to content

plugin_ffi template test run ffigen #105688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dcharkes wants to merge 20 commits into from
Closed

plugin_ffi template test run ffigen #105688

dcharkes wants to merge 20 commits into from

Conversation

@dcharkes
Copy link
Contributor

@dcharkes dcharkes commented Jun 9, 2022

Run ffigen on the generated bindings of the plugin_ffi template to check that they are up to date.

Requirements

This requires libclang on the bots.

Creating this PR to see on which bots it fails.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 9, 2022
@dcharkes dcharkes marked this pull request as draft June 9, 2022 11:07
@dcharkes dcharkes mentioned this pull request Jun 9, 2022
Open
@dcharkes dcharkes mentioned this pull request Jun 14, 2022
Merged
@dcharkes
Copy link
Contributor Author

dcharkes commented Jun 14, 2022

The test running ffigen now succeeds on the Cirrus CI bot:

https://cirrus-ci.com/task/5862838391537664

@dcharkes dcharkes mentioned this pull request Jun 15, 2022
Closed
@dcharkes
Copy link
Contributor Author

dcharkes commented Aug 2, 2022

Abandoning this PR because we don't want to run Flutter tests on the Github CI.

@dcharkes dcharkes closed this Aug 2, 2022
@dcharkes dcharkes deleted the test-plugin-ffi-run-ffigen branch December 19, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dcharkes