Skip to content

Add error messages to _debugCanPerformMutations #105638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 8 commits into from
Jul 2, 2022
Merged

Add error messages to _debugCanPerformMutations #105638

auto-submit merged 8 commits into from
Jul 2, 2022

Conversation

@LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Jun 8, 2022 •
edited
Loading

Separated from #105335. TGP passed: OCL:453732336:BASE:453732204:1654815855431:ecc85b03

Fixes #87423 I guess

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Jun 8, 2022
@LongCatIsLooong LongCatIsLooong force-pushed the _debugCanPerformMutations branch from ba513f2 to 9c17dab Compare June 9, 2022 07:42
@LongCatIsLooong LongCatIsLooong marked this pull request as ready for review June 9, 2022 16:00
goderbauer
goderbauer reviewed Jul 1, 2022
View reviewed changes
packages/flutter/lib/src/rendering/object.dart Outdated
Copy link
Member

@goderbauer goderbauer Jul 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, this condition was checked on every node on the path to the activeLayoutRoute, but now it is only checked for the activeLayoutRoot. For my own understanding, why is this change considered ok?

Copy link
Contributor Author

@LongCatIsLooong LongCatIsLooong Jul 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original implementation seems to make more sense. Changed.

packages/flutter/lib/src/rendering/object.dart Outdated
Copy link
Member

@goderbauer goderbauer Jul 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other methods then markNeedsLayout check _debugCanPerformMutations - wouldn't this message be confusing in those cases?

Copy link
Contributor Author

@LongCatIsLooong LongCatIsLooong Jul 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed was marked as needing layout to was mutated.

packages/flutter/test/rendering/mutations_test.dart Outdated
Comment on lines 135 to 136
Copy link
Member

@goderbauer goderbauer Jul 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should test that the right ROs are mentioned in these errors.

goderbauer
goderbauer approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter/lib/src/rendering/object.dart Outdated
Copy link
Member

@goderbauer goderbauer Jul 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: inconsistent quotes

packages/flutter/lib/src/rendering/object.dart Outdated
Copy link
Member

@goderbauer goderbauer Jul 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you actually need the result variable anymore? Seems like this either returns true now or it throws so we could simplify the code and remove this?

Copy link
Contributor Author

@LongCatIsLooong LongCatIsLooong Jul 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only when the result is true I think (so the assert doesn't assert). One thing this provides is since result is a late final, if _debugCanPerformMutations is accidentally called in release mode it crashes.

@LongCatIsLooong LongCatIsLooong force-pushed the _debugCanPerformMutations branch from efaf1b9 to ff8a28d Compare July 2, 2022 00:26
@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 2, 2022
@auto-submit auto-submit bot merged commit 09a5382 into flutter:master Jul 2, 2022
@LongCatIsLooong LongCatIsLooong deleted the _debugCanPerformMutations branch July 2, 2022 01:13
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 2, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 2, 2022
@engine-flutter-autoroll
09a5382 Add error messages to _debugCanPerformMutations (flutter/fl…
a231d73 
…utter#105638)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 2, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2022
@engine-flutter-autoroll
09a5382 Add error messages to _debugCanPerformMutations (flutter/fl…
7a7cf33 
…utter#105638)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@LongCatIsLooong @camsim99
Add error messages to _debugCanPerformMutations (flutter#105638)
4fff85b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
09a5382 Add error messages to _debugCanPerformMutations (flutter/fl…
f29a900 
…utter#105638)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
09a5382 Add error messages to _debugCanPerformMutations (flutter/fl…
7717d3e 
…utter#105638)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

_debugCanPerformMutations assert improvements

2 participants

@LongCatIsLooong @goderbauer