Skip to content

Make flutter attach respect the --dds-port flag. #105560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
Jun 9, 2022
Merged

Make flutter attach respect the --dds-port flag. #105560

fluttergithubbot merged 2 commits into from
Jun 9, 2022

Conversation

@chingjun
Copy link
Contributor

@chingjun chingjun commented Jun 8, 2022

Flutter attach used to ignore the --dds-port flag.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 8, 2022
@chingjun chingjun changed the title [WIP] Make flutter attach respect the --dds-port flag. Make flutter attach respect the --dds-port flag. Jun 8, 2022
@chingjun
Copy link
Contributor Author

chingjun commented Jun 8, 2022

Note: most of the diff in the test file was just me moving the test cases into a separate group. One of the original tests need to run with DDS started on the run process, but the new test I added needs to be started in the attach process, so I moved all the existing tests into a group, and added my test in a new group.

christopherfujino
christopherfujino approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fluttergithubbot fluttergithubbot merged commit d30ad47 into flutter:master Jun 9, 2022
This was referenced Jun 10, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
d30ad47 Make flutter attach respect the --dds-port flag. (flutter/f…
1c5bbe6 
…lutter#105560)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
d30ad47 Make flutter attach respect the --dds-port flag. (flutter/f…
18dbbad 
…lutter#105560)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
d30ad47 Make flutter attach respect the --dds-port flag. (flutter/f…
62990de 
…lutter#105560)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
d30ad47 Make flutter attach respect the --dds-port flag. (flutter/f…
00dd140 
…lutter#105560)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
d30ad47 Make flutter attach respect the --dds-port flag. (flutter/f…
c3b9c44 
…lutter#105560)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
d30ad47 Make flutter attach respect the --dds-port flag. (flutter/f…
1fe8f53 
…lutter#105560)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
d30ad47 Make flutter attach respect the --dds-port flag. (flutter/f…
0e4991d 
…lutter#105560)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
d30ad47 Make flutter attach respect the --dds-port flag. (flutter/f…
50f7dc7 
…lutter#105560)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
d30ad47 Make flutter attach respect the --dds-port flag. (flutter/f…
c3d3136 
…lutter#105560)
This was referenced Jun 11, 2022
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 11, 2022
@engine-flutter-autoroll
d30ad47 Make flutter attach respect the --dds-port flag. (flutter/f…
c073b7f 
…lutter#105560)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 11, 2022
@engine-flutter-autoroll
d30ad47 Make flutter attach respect the --dds-port flag. (flutter/f…
4025dcc 
…lutter#105560)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 11, 2022
@engine-flutter-autoroll
d30ad47 Make flutter attach respect the --dds-port flag. (flutter/f…
fe2a5de 
…lutter#105560)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2022
@engine-flutter-autoroll
d30ad47 Make flutter attach respect the --dds-port flag. (flutter/f…
6680be3 
…lutter#105560)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2022
@engine-flutter-autoroll
d30ad47 Make flutter attach respect the --dds-port flag. (flutter/f…
0149612 
…lutter#105560)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 13, 2022
@engine-flutter-autoroll
d30ad47 Make flutter attach respect the --dds-port flag. (flutter/f…
5dfd6bc 
…lutter#105560)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 13, 2022
@engine-flutter-autoroll
d30ad47 Make flutter attach respect the --dds-port flag. (flutter/f…
f6b0870 
…lutter#105560)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
@engine-flutter-autoroll
d30ad47 Make flutter attach respect the --dds-port flag. (flutter/f…
378ab8f 
…lutter#105560)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
@engine-flutter-autoroll
d30ad47 Make flutter attach respect the --dds-port flag. (flutter/f…
b8d9c32 
…lutter#105560)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
@engine-flutter-autoroll
d30ad47 Make flutter attach respect the --dds-port flag. (flutter/f…
a8a7c42 
…lutter#105560)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@chingjun @camsim99
Make flutter attach respect the --dds-port flag. (flutter#105560)
cc488f4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
d30ad47 Make flutter attach respect the --dds-port flag. (flutter/f…
3f66fa6 
…lutter#105560)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
d30ad47 Make flutter attach respect the --dds-port flag. (flutter/f…
e8a6eb3 
…lutter#105560)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chingjun @christopherfujino @fluttergithubbot