Fix DraggableScrollableSheet crash when switching out scrollables #105549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: scrolling
Piinks
changed the title
dnfield
reviewed
Jun 7, 2022
Comment on lines
634
to
651
Contributor
There was a problem hiding this comment.
nit: _replacedExtent is only used here. I think it'd make sense to either inline the function here or to keep all this logic in the function.
Contributor
Author
|
I am still working with the customer on this to ensure their issue is resolved, marking WIP for now |
Piinks
changed the title
Piinks
changed the title
Contributor
Author
|
@dnfield I've cleaned this up and confirmed with the customer that this does resolve their issue. Can you PTAL when you have a chance? Thanks! |
dnfield
approved these changes
Jun 30, 2022
xu-baolin
added
the
autosubmit
Contributor
|
auto-submit
bot
removed
the
autosubmit
Contributor
@keyonghan this is a bug. The auto submit bot should not be removing the label for this check. |
Piinks
added
waiting for tree to go green
autosubmit
Contributor
|
auto-submit
bot
removed
the
autosubmit
Contributor
|
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 1, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 1, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105469
This accounts for when there is more than one position is attached to the scroll controller, and only triggers a snap when appropriate.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.