Implement frameData for TestWindow #105537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: tests
goderbauer
approved these changes
Jun 27, 2022
| } | ||
| _phase = newPhase; | ||
| if (hasScheduledFrame) { | ||
| addTime(const Duration(milliseconds: 500)); |
Member
There was a problem hiding this comment.
Why these removals? Seems unrelated to the goal of the PR?
Contributor
Author
There was a problem hiding this comment.
addTime is deprecated and implemented as a no-op. I can remove this from this PR, but it caused confusion for me when tracing through to figure out what was missing.
Member
There was a problem hiding this comment.
I see. It's fine to leave the removal in this PR :)
dnfield
added
the
autosubmit
This was referenced Jun 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 28, 2022
XilaiZhang
added a commit
to XilaiZhang/flutter
that referenced
this pull request
Jul 6, 2022
This reverts commit 21841d7.
XilaiZhang
added a commit
to XilaiZhang/flutter
that referenced
this pull request
Jul 6, 2022
This reverts commit 21841d7.
XilaiZhang
added a commit
that referenced
this pull request
Jul 6, 2022
XilaiZhang
added a commit
that referenced
this pull request
Jul 6, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
…lutter#107168) * Revert "Reland "Clipping if only one character text overflows (flutter#99146)" (flutter#102130)" This reverts commit 3f43d9f. * Revert "Implement frameData for TestWindow (flutter#105537)" This reverts commit 21841d7.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105530