-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Add targets for benchmark tests moved from staging to prod. #105481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ricardoamador
merged 7 commits into
flutter:master
from
ricardoamador:move_devicelab_benchmark_builders_staging_to_prod
Jun 7, 2022
Merged
Add targets for benchmark tests moved from staging to prod. #105481
ricardoamador
merged 7 commits into
flutter:master
from
ricardoamador:move_devicelab_benchmark_builders_staging_to_prod
Jun 7, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyonghan
reviewed
Jun 6, 2022
…hmark_builders_staging_to_prod
…hmark_builders_staging_to_prod
keyonghan
reviewed
Jun 7, 2022
Contributor
keyonghan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yusuf-goog
approved these changes
Jun 7, 2022
CaseyHillers
approved these changes
Jun 7, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 8, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
…105481) * Add targets for benchmark tests moved from staging to prod. * Add bringup:true to new targets. * Missed a builder for bringup. * Fix a presubmit that was inadvertently created as true. * Removed some trailing whitespace causing format check to fail.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of The Issue Being Addressed
We are moving the linux/android builders back to prod from staging as the flakiness has been addressed.
Issues Addressed
#105468
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.