Skip to content

Conversation

@ricardoamador
Copy link
Contributor

@ricardoamador ricardoamador commented Jun 6, 2022

Description of The Issue Being Addressed

We are moving the linux/android builders back to prod from staging as the flakiness has been addressed.

Issues Addressed

#105468

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ricardoamador ricardoamador requested a review from keyonghan as a code owner June 6, 2022 23:21
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardoamador ricardoamador merged commit 80bfc8f into flutter:master Jun 7, 2022
@ricardoamador ricardoamador deleted the move_devicelab_benchmark_builders_staging_to_prod branch June 7, 2022 21:12
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 8, 2022
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
…105481)

* Add targets for benchmark tests moved from staging to prod.

* Add bringup:true to new targets.

* Missed a builder for bringup.

* Fix a presubmit that was inadvertently created as true.

* Removed some trailing whitespace causing format check to fail.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants