[framework] respect debugDisableShadows in slider thumbs #105467
Conversation
flutter-dashboard
bot
added
f: material design
| canvas.drawShadow(path, Colors.black, evaluatedElevation, true); | ||
|
|
||
| bool paintShadows = true; | ||
| assert(() { |
There was a problem hiding this comment.
nit: move this to a helper method instead of repeating the same code below.
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
3 participants
I've tracked down the shadows in the slider thumb as the cause of flakiness in b/234804037 which blocks migration to fractional tester. These shadows should respect the debug setting so we can avoid indeterminacy.