Skip to content

Conversation

@youssef-attia
Copy link
Contributor

Added an example for IndexedStack widget

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jun 3, 2022
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you use the formatter as a starting point, it's important to know that adding and removing commas at the ends of parameter lists and arrays indicates whether or not you want all attributes on separate lines or not.

youssef-attia and others added 2 commits June 3, 2022 12:30
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for all the formatting nits. It's just the usual getting used to the coding style in the Flutter repo.

Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@youssef-attia youssef-attia merged commit 0825603 into flutter:master Jun 13, 2022
@youssef-attia youssef-attia deleted the indexedStackExample branch June 13, 2022 23:38
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
@youssef-attia youssef-attia restored the indexedStackExample branch June 27, 2022 17:49
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
* Added an example for IndexedStack

* Added tests for the IndexedStack example

* Fixed type issue for onSubmitted callback functions

* Fixed documentation and moved files to their appropriate places

* Fixed documentation and moved files to their appropriate places

* Moved test files to their appropriate places

* Moved test files to their appropriate places

* Fixed file path in documentation

* Remove trailing space

* Formatting changes

* Remove extra line

* Further formatting changes

* Further formatting changes

* fix comma and inline

Co-authored-by: Greg Spencer <[email protected]>

* Formatting

* indentation and formatting

* Formatting

* Formatting

* Formatting

* Removed duplicate chevron

* better wording on documentation

Co-authored-by: Tong Mu <[email protected]>

* Added testing for state preservation

Co-authored-by: Greg Spencer <[email protected]>
Co-authored-by: Tong Mu <[email protected]>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants