Skip to content

Revert "[DataTable]: Add ability to only select row using checkbox (#105123)" #105311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Jun 3, 2022
Merged

Revert "[DataTable]: Add ability to only select row using checkbox (#105123)" #105311

fluttergithubbot merged 1 commit into from
Jun 3, 2022

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Jun 3, 2022 •
edited
Loading

Reverts #105123

Using the old Flutter version, it looks like it was a bug with onSelectChanged callback condition fixed in the latest Flutter version so we don't need this ability. Reverting this ability.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 3, 2022
@TahaTesser TahaTesser requested a review from guidezpl June 3, 2022 13:58
@TahaTesser TahaTesser changed the title Revert "[DataTable]: Add ability to only select row using checkbox (#105123) Revert "[DataTable]: Add ability to only select row using checkbox (#105123)" Jun 3, 2022
@fluttergithubbot fluttergithubbot merged commit d4a9631 into flutter:master Jun 3, 2022
@TahaTesser TahaTesser deleted the revert-data-table branch June 3, 2022 14:20
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
d4a9631 Revert "[DataTable]: Add ability to only select row using che…
54a052e 
…ckbox (#105123)" (flutter/flutter#105311)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
d4a9631 Revert "[DataTable]: Add ability to only select row using che…
f76fb5c 
…ckbox (#105123)" (flutter/flutter#105311)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
d4a9631 Revert "[DataTable]: Add ability to only select row using che…
151f6d8 
…ckbox (#105123)" (flutter/flutter#105311)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
d4a9631 Revert "[DataTable]: Add ability to only select row using che…
687b729 
…ckbox (#105123)" (flutter/flutter#105311)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
d4a9631 Revert "[DataTable]: Add ability to only select row using che…
3f2fb16 
…ckbox (#105123)" (flutter/flutter#105311)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
d4a9631 Revert "[DataTable]: Add ability to only select row using che…
c5511b8 
…ckbox (#105123)" (flutter/flutter#105311)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
d4a9631 Revert "[DataTable]: Add ability to only select row using che…
2bf54e2 
…ckbox (#105123)" (flutter/flutter#105311)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
d4a9631 Revert "[DataTable]: Add ability to only select row using che…
d4b78be 
…ckbox (#105123)" (flutter/flutter#105311)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
d4a9631 Revert "[DataTable]: Add ability to only select row using che…
12ee9f3 
…ckbox (#105123)" (flutter/flutter#105311)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
d4a9631 Revert "[DataTable]: Add ability to only select row using che…
298a1d2 
…ckbox (#105123)" (flutter/flutter#105311)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
d4a9631 Revert "[DataTable]: Add ability to only select row using che…
9e1dfda 
…ckbox (#105123)" (flutter/flutter#105311)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
d4a9631 Revert "[DataTable]: Add ability to only select row using che…
b555055 
…ckbox (#105123)" (flutter/flutter#105311)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
d4a9631 Revert "[DataTable]: Add ability to only select row using che…
0f26604 
…ckbox (#105123)" (flutter/flutter#105311)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
d4a9631 Revert "[DataTable]: Add ability to only select row using che…
f55a6b8 
…ckbox (#105123)" (flutter/flutter#105311)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
d4a9631 Revert "[DataTable]: Add ability to only select row using che…
f6bb190 
…ckbox (#105123)" (flutter/flutter#105311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
d4a9631 Revert "[DataTable]: Add ability to only select row using che…
3e81501 
…ckbox (#105123)" (flutter/flutter#105311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
d4a9631 Revert "[DataTable]: Add ability to only select row using che…
58d5326 
…ckbox (#105123)" (flutter/flutter#105311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
d4a9631 Revert "[DataTable]: Add ability to only select row using che…
3c95111 
…ckbox (#105123)" (flutter/flutter#105311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
d4a9631 Revert "[DataTable]: Add ability to only select row using che…
00d4ee3 
…ckbox (#105123)" (flutter/flutter#105311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
d4a9631 Revert "[DataTable]: Add ability to only select row using che…
ddfda81 
…ckbox (#105123)" (flutter/flutter#105311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
d4a9631 Revert "[DataTable]: Add ability to only select row using che…
4f5494b 
…ckbox (#105123)" (flutter/flutter#105311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
d4a9631 Revert "[DataTable]: Add ability to only select row using che…
b0b7eb5 
…ckbox (#105123)" (flutter/flutter#105311)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@TahaTesser @camsim99
Revert "[DataTable]: Add ability to only select row using checkbox (f…
f717ee0 
…lutter#105123)" (flutter#105311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
d4a9631 Revert "[DataTable]: Add ability to only select row using che…
ee3dc6c 
…ckbox (#105123)" (flutter/flutter#105311)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
d4a9631 Revert "[DataTable]: Add ability to only select row using che…
2903aa7 
…ckbox (#105123)" (flutter/flutter#105311)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guidezpl guidezpl guidezpl approved these changes

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TahaTesser @guidezpl @fluttergithubbot