Update parameters to the styleFrom button methods.
#105291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: accessibility
Contributor
Author
|
This will require #105290 to land first, as the deprecation versions are now using beta releases, not dev releases. |
8 tasks
guidezpl
approved these changes
Jun 3, 2022
Member
guidezpl
left a comment
guidezpl
left a comment
There was a problem hiding this comment.
This is clean.
_ ___ _____ __ __
| | / __|_ _| \/ |
| |_| (_ | | | | |\/| |
|____\___| |_| |_| |_|
This was referenced Jun 3, 2022
darrenaustin
added a commit
to darrenaustin/plugins
that referenced
this pull request
Jun 9, 2022
…l need to be migrated when flutter/flutter#105291 lands on stable.
darrenaustin
added a commit
to darrenaustin/plugins
that referenced
this pull request
Jun 10, 2022
…l need to be migrated when flutter/flutter#105291 lands on stable.
darrenaustin
added a commit
to darrenaustin/plugins
that referenced
this pull request
Jun 13, 2022
…l need to be migrated when flutter/flutter#105291 lands on stable.
darrenaustin
added a commit
to darrenaustin/plugins
that referenced
this pull request
Jun 15, 2022
…l need to be migrated when flutter/flutter#105291 lands on stable.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 22, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 22, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 22, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 22, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 22, 2022
Contributor
|
This PR appears to have broken the flutter-analyze bot on the Dart build system. Based on the log output: it appears that the flutter gallery app is still using This suggests that the flutter gallery app is not being analyzed as part of the build process, which might indicate a different kind of issue. |
Member
|
You may want use pinning to allow fixes for changes such as this to get in without breaking builds. See also https://github.com/flutter/gallery#tests. |
Contributor
|
@athomas for the previous comment. |
Contributor
|
The point of the multi headed testing is to detect problems before the rolls, and pinning would defeat that. |
Contributor
|
Looks like some of the API docs still refer to |
8 tasks
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
* Update parameters to the `styleFrom` button methods. * Updated the Flutter fix data to point to this PR. * Updated handling of background color to better maintain backwards compatibility with previous API.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Dec 5, 2023
…s from `ElevatedButton.styleFrom` (#5566) This PR is to remove deprecated `primary` and `onPrimary` references([deprecation PR](flutter/flutter#105291)) from `ElevatedButton.styleFrom`. `primary` should be replaced with `backgroundColor` and `onPrimary` should be replaced with `foregroundColor`. No new tests needed. Please let me know if I incorrectly handled the CHANGELOG and version change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the common button
.styleFrommethods a little easier to use, this PR adds the following parameters to each ofElevatedButton.styleFrom,OutlinedButton.styleFromandTextButton.styleFrom:If given they will be used to construct foreground and background MaterialStateProperty colors for the style. These replace
primary,onPrimary, andonSurfacewhich are deprecated.To update your apps to use these new parameters you can either use the quick fix feature of your IDE, or use Flutter Fix to apply the given fixes to your entire project.
Pre-launch Checklist
///).