Skip to content

Reland: "Add example and troubleshooting comment for showSnackBar" #105195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Aug 9, 2022
Merged

Reland: "Add example and troubleshooting comment for showSnackBar" #105195

auto-submit merged 1 commit into from
Aug 9, 2022

Conversation

@bleroux
Copy link
Contributor

@bleroux bleroux commented Jun 2, 2022

Description

Reland #102073, which was reverted in #104843

Related issues

Fixes #84263

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jun 2, 2022
@bleroux bleroux requested a review from Piinks June 2, 2022 06:31
Piinks
Piinks approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but do not land this, checking the affected customer tests first.

Piinks
Piinks reviewed Jun 9, 2022
View reviewed changes
packages/flutter/lib/src/material/scaffold.dart Outdated
Copy link
Contributor

@Piinks Piinks Jun 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
final bool snackBarVisible = (snackBarYOffsetBase - snackBarSize.height) > 0;
final bool snackBarVisible = (snackBarYOffsetBase - snackBarSize.height) >= 0;

Should this be >= ? Wouldn't a position at the top edge be valid?

Copy link
Contributor Author

@bleroux bleroux Jun 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I pushed a fix and updated the related test to check several SnackBar positions (fully offscreen, partially offscreen, right on the top). Thanks!.

@bleroux bleroux force-pushed the floating_snackbar_troubleshooting branch 4 times, most recently from 29ff0ea to be616e6 Compare June 11, 2022 08:45
@bleroux bleroux requested a review from Piinks June 13, 2022 05:56
Piinks
Piinks reviewed Aug 1, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bleroux can you update this branch with the latest from master? There was a big braking change I was helping @TahaTesser get in first. I think we can move this forward now once it is updated.

I appreciate your patience. I try to migrate customers for one change at a time to keep it sane and organized. :)

@bleroux bleroux force-pushed the floating_snackbar_troubleshooting branch from be616e6 to a1e07f8 Compare August 2, 2022 11:17
@bleroux
Copy link
Contributor Author

bleroux commented Aug 2, 2022

Hey @Piinks!

I have rebased the PR, it seems to be ok.

I appreciate your patience. I try to migrate customers for one change at a time to keep it sane and organized. :)

I really appreciate your reviews too! You do such a great job: working on your own PRs, reviewing relentlessly other contributors' PRs, addressing customers migration and also participating in many Flutter team great videos! 💙

@Piinks
Copy link
Contributor

Piinks commented Aug 9, 2022

Thanks very much! I am running against internal tests now.

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 9, 2022
@auto-submit auto-submit bot merged commit 8faccb8 into flutter:master Aug 9, 2022
@Piinks
Copy link
Contributor

Piinks commented Aug 9, 2022

Thanks for your patience! All of the customers are fixed. 🎉

@bleroux bleroux deleted the floating_snackbar_troubleshooting branch August 10, 2022 06:55
This was referenced Aug 10, 2022
Merged
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 10, 2022
@engine-flutter-autoroll
8faccb8 Reland: "Add example and troubleshooting comment for `showSna…
f091e0c 
…ckBar`" (flutter/flutter#105195)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 10, 2022
@engine-flutter-autoroll
8faccb8 Reland: "Add example and troubleshooting comment for `showSna…
3735a92 
…ckBar`" (flutter/flutter#105195)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 10, 2022
@engine-flutter-autoroll
8faccb8 Reland: "Add example and troubleshooting comment for `showSna…
0620274 
…ckBar`" (flutter/flutter#105195)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 10, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 10, 2022
@engine-flutter-autoroll
8faccb8 Reland: "Add example and troubleshooting comment for `showSna…
e8b9aa7 
…ckBar`" (flutter/flutter#105195)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@bleroux @camsim99
Reland: "Add example and troubleshooting comment for showSnackBar" (f…
a6822ae 
…lutter#105195)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Snackbar with SnackBarBehavior.floating is affected by widgets provided to floatingActionButton parameter in the Scaffold

2 participants

@bleroux @Piinks