Skip to content

Update README to respect GitHub site theme #105189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guidezpl merged 2 commits into from
Jun 2, 2022
Merged

Update README to respect GitHub site theme #105189

guidezpl merged 2 commits into from
Jun 2, 2022

Conversation

@cadenkriese
Copy link
Contributor

@cadenkriese cadenkriese commented Jun 2, 2022

GitHub recently added support for specifying an alternate appearance when the site is using a dark theme (see the changelog). I've implemented this here with download links from https://flutter.dev/brand.

Before:
before

After:
after

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

Requesting test exemption @Hixie

Hixie
Hixie reviewed Jun 2, 2022
View reviewed changes
@Hixie
Copy link
Contributor

Hixie commented Jun 2, 2022

This is great!

@cadenkriese cadenkriese requested a review from Hixie June 2, 2022 08:03
guidezpl
guidezpl approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice on the eyes

@guidezpl guidezpl merged commit 3c6719b into flutter:master Jun 2, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
3c6719b Update README to respect GitHub site theme (flutter/flutter#1…
1404f88 
…05189)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
3c6719b Update README to respect GitHub site theme (flutter/flutter#1…
2f67935 
…05189)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
3c6719b Update README to respect GitHub site theme (flutter/flutter#1…
7bf36d7 
…05189)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
3c6719b Update README to respect GitHub site theme (flutter/flutter#1…
5936a88 
…05189)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
3c6719b Update README to respect GitHub site theme (flutter/flutter#1…
f187f69 
…05189)
@cadenkriese cadenkriese deleted the patch-1 branch June 2, 2022 18:23
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
3c6719b Update README to respect GitHub site theme (flutter/flutter#1…
f38c814 
…05189)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
3c6719b Update README to respect GitHub site theme (flutter/flutter#1…
e70d7c8 
…05189)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
3c6719b Update README to respect GitHub site theme (flutter/flutter#1…
9b5c355 
…05189)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
3c6719b Update README to respect GitHub site theme (flutter/flutter#1…
69f5f3c 
…05189)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
3c6719b Update README to respect GitHub site theme (flutter/flutter#1…
0a6cfa5 
…05189)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
3c6719b Update README to respect GitHub site theme (flutter/flutter#1…
63cc6a4 
…05189)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
3c6719b Update README to respect GitHub site theme (flutter/flutter#1…
92fcdd2 
…05189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
3c6719b Update README to respect GitHub site theme (flutter/flutter#1…
3a9d8b9 
…05189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
3c6719b Update README to respect GitHub site theme (flutter/flutter#1…
592c16e 
…05189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
3c6719b Update README to respect GitHub site theme (flutter/flutter#1…
f84ff67 
…05189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
3c6719b Update README to respect GitHub site theme (flutter/flutter#1…
3eaa523 
…05189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
3c6719b Update README to respect GitHub site theme (flutter/flutter#1…
f2f3437 
…05189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
3c6719b Update README to respect GitHub site theme (flutter/flutter#1…
77b62f5 
…05189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
3c6719b Update README to respect GitHub site theme (flutter/flutter#1…
29b870e 
…05189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
3c6719b Update README to respect GitHub site theme (flutter/flutter#1…
7eec7c6 
…05189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
3c6719b Update README to respect GitHub site theme (flutter/flutter#1…
d2fba1b 
…05189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
3c6719b Update README to respect GitHub site theme (flutter/flutter#1…
5bcb7d8 
…05189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
3c6719b Update README to respect GitHub site theme (flutter/flutter#1…
1dc57cf 
…05189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
3c6719b Update README to respect GitHub site theme (flutter/flutter#1…
e28386f 
…05189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
3c6719b Update README to respect GitHub site theme (flutter/flutter#1…
d209b93 
…05189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
3c6719b Update README to respect GitHub site theme (flutter/flutter#1…
8b84e56 
…05189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
3c6719b Update README to respect GitHub site theme (flutter/flutter#1…
0b7495c 
…05189)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@cadenkriese @camsim99
Update README to respect GitHub site theme (flutter#105189)
1fa555d 
* Update README to respect GitHub site theme

GitHub recently added support for specifying an alternate appearance when the site is using a dark theme [(see the changelog)](https://github.blog/changelog/2022-05-19-specify-theme-context-for-images-in-markdown-beta/). I've implemented this here with download links from https://flutter.dev/brand.

* Change alt text
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
3c6719b Update README to respect GitHub site theme (flutter/flutter#1…
ab3fed3 
…05189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
3c6719b Update README to respect GitHub site theme (flutter/flutter#1…
0f95fc8 
…05189)
@timsneath timsneath mentioned this pull request Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guidezpl guidezpl guidezpl approved these changes

@Hixie Hixie Awaiting requested review from Hixie

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cadenkriese @Hixie @guidezpl