Skip to content

flutter drive --enable-software-rendering --skia-deterministic-rendering #105161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Jun 2, 2022
Merged

flutter drive --enable-software-rendering --skia-deterministic-rendering #105161

fluttergithubbot merged 1 commit into from
Jun 2, 2022

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Jun 1, 2022

Plugins CI wants to use flutter drive --enable-software-rendering to work around a Metal virtualization bug on arm Mac machines. Move it and --skia-deterministic-rendering (they are related) from run to the base.

Part of #104523 (comment) (they also want test but this was the easy part).

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 1, 2022
@jmagman jmagman self-assigned this Jun 1, 2022
@jmagman jmagman marked this pull request as ready for review June 1, 2022 19:08
christopherfujino
christopherfujino approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 208a418 into flutter:master Jun 2, 2022
@jmagman jmagman deleted the software-rendering branch June 2, 2022 20:43
@jmagman jmagman mentioned this pull request Jun 2, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
208a418 flutter drive --enable-software-rendering --skia-deterministi…
d6092fc 
…c-rendering (flutter/flutter#105161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
208a418 flutter drive --enable-software-rendering --skia-deterministi…
fcccf83 
…c-rendering (flutter/flutter#105161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
208a418 flutter drive --enable-software-rendering --skia-deterministi…
58f1e8c 
…c-rendering (flutter/flutter#105161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
208a418 flutter drive --enable-software-rendering --skia-deterministi…
f2ce31e 
…c-rendering (flutter/flutter#105161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
208a418 flutter drive --enable-software-rendering --skia-deterministi…
b6f8936 
…c-rendering (flutter/flutter#105161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
208a418 flutter drive --enable-software-rendering --skia-deterministi…
88f8fe3 
…c-rendering (flutter/flutter#105161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
208a418 flutter drive --enable-software-rendering --skia-deterministi…
2000a7a 
…c-rendering (flutter/flutter#105161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
208a418 flutter drive --enable-software-rendering --skia-deterministi…
8757d12 
…c-rendering (flutter/flutter#105161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
208a418 flutter drive --enable-software-rendering --skia-deterministi…
c97cf23 
…c-rendering (flutter/flutter#105161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
208a418 flutter drive --enable-software-rendering --skia-deterministi…
b516908 
…c-rendering (flutter/flutter#105161)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
208a418 flutter drive --enable-software-rendering --skia-deterministi…
8ed69eb 
…c-rendering (flutter/flutter#105161)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
208a418 flutter drive --enable-software-rendering --skia-deterministi…
a143620 
…c-rendering (flutter/flutter#105161)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
208a418 flutter drive --enable-software-rendering --skia-deterministi…
d6c4919 
…c-rendering (flutter/flutter#105161)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
208a418 flutter drive --enable-software-rendering --skia-deterministi…
ea349d4 
…c-rendering (flutter/flutter#105161)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
208a418 flutter drive --enable-software-rendering --skia-deterministi…
a970b87 
…c-rendering (flutter/flutter#105161)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
208a418 flutter drive --enable-software-rendering --skia-deterministi…
d218556 
…c-rendering (flutter/flutter#105161)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
208a418 flutter drive --enable-software-rendering --skia-deterministi…
63abeeb 
…c-rendering (flutter/flutter#105161)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
208a418 flutter drive --enable-software-rendering --skia-deterministi…
bedc1a7 
…c-rendering (flutter/flutter#105161)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
208a418 flutter drive --enable-software-rendering --skia-deterministi…
9d2397e 
…c-rendering (flutter/flutter#105161)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
208a418 flutter drive --enable-software-rendering --skia-deterministi…
41aa254 
…c-rendering (flutter/flutter#105161)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
208a418 flutter drive --enable-software-rendering --skia-deterministi…
b60aa17 
…c-rendering (flutter/flutter#105161)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
208a418 flutter drive --enable-software-rendering --skia-deterministi…
709cddc 
…c-rendering (flutter/flutter#105161)
@jmagman jmagman mentioned this pull request Jun 7, 2022
Closed
11 tasks
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@jmagman @camsim99
flutter drive --enable-software-rendering --skia-deterministic-render…
1b8857b 
…ing (flutter#105161)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
208a418 flutter drive --enable-software-rendering --skia-deterministi…
edf766f 
…c-rendering (flutter/flutter#105161)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
208a418 flutter drive --enable-software-rendering --skia-deterministi…
9ab3b29 
…c-rendering (flutter/flutter#105161)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jasguerrero Jasguerrero Awaiting requested review from Jasguerrero

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @christopherfujino @fluttergithubbot