-
Notifications
You must be signed in to change notification settings - Fork 29.7k
[DataTable]: Add ability to only select row using checkbox #105123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataTable]: Add ability to only select row using checkbox #105123
Conversation
| /// tap or long press. | ||
| /// | ||
| /// This value is true by default. | ||
| final bool selectableOnGestures; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there reference to this in spec? I imagine this would be a mobile/tablet behavior only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't find any specs, this is in response to the users in #70755.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine this would be a mobile/tablet behavior only.
This is for all platforms where we don't expect users to tap the row when onTap or long-press are not implemented but only onSelectChanged, which makes the row tappable with inkwell effect and also affects accessibility (talkback says "double-tap to activate").
onTap == null and onSelectChanged != null wraps label with InkWell.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. Can you please add an explanation for how this interacts with onSelectChanged and onRowLongPress?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an explanation, please take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
guidezpl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_ ___ _____ __ __
| | / __|_ _| \/ |
| |_| (_ | | | | |\/| |
|____\___| |_| |_| |_|
…lutter#105123)" This reverts commit 5fe7854.
fixes #70755
minimal code sample
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.